New issue
Advanced search Search tips

Issue 869036 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT] New failures introduced in external/wpt/webrtc by import https://crrev.com/c/1154996

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jul 30

Issue description

WPT import https://crrev.com/c/1154996 introduced new failures in external/wpt/webrtc:

List of new failures:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-transceivers.https.html new failing tests: https://crrev.com/c/1154996/4/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-transceivers.https-expected.txt

This import contains upstream changes from 24c4f1e5c434a5ad018aa7467b7bfcffca764b8d to ae1d73a946c326315d875206c766656c064395fd:
Update the webgl2 IDL file (#12197): https://github.com/web-platform-tests/wpt/commit/ae1d73a946c326315d875206c766656c064395fd
Merge pull request #12141 from fippo/remember-firefox: https://github.com/web-platform-tests/wpt/commit/00d1189bc19907a981ee8ee9b90229121bf3ac51
Revert "html: Split semantics/tabular-data/processing-model-1/span-limits.html into two.": https://github.com/web-platform-tests/wpt/commit/d892efb842377ae0b73b39a0d0a80f0b9a998c8f
webrtc: make transceiver tests work in Firefox: https://github.com/web-platform-tests/wpt/commit/ed8099ac2129f3f7a0f9f3a5e30e3b581d54cdee [affecting this directory]

 
Cc: philipp....@googlemail.com
Owner: hbos@chromium.org
Status: Started (was: Untriaged)
The failure was introduced due to a bug introduced in one of the tests in this PR: https://github.com/web-platform-tests/wpt/pull/12141

The addTrack(0 streams) test should not take any stream as argument to addTrack.

I'll create a fix, that is easier than reverting.
Components: -Blink>WebRTC Blink>WebRTC>PeerConnection
Labels: M-70 Pri-3
Components: -Blink>WebRTC>PeerConnection Blink>WebRTC
Labels: -Pri-3 -M-70
ugh... why didn't the tests fail on github?
I think because the failure only occurs when the test runs, which is when Unified Plan is enabled, which isn't the default. WPT bots don't know about that.
one more reason to land stuff via chrome then. Thank you!
Yes - better reviewing tools and better bots! Chrome bots don't run Firefox though.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e653e90ca6a59abbeaed25191c27b9a77a788b2b

commit e653e90ca6a59abbeaed25191c27b9a77a788b2b
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Jul 31 08:06:52 2018

Fix RTCPeerConnection-transceivers.https.html bug.

This PR accidentally made the "addTrack(0 streams)" test call addTrack()
with a stream, which broke the tests:
https://github.com/web-platform-tests/wpt/pull/12141

Test restored and all "addTrack/addTransceiver(X streams)" are made to
consistently use "new MediaStream()" the same way.

Bug:  869036 
Change-Id: Ieaf0c73a1996aeb2e87e18f2f9065fa1e6fee1e7
Reviewed-on: https://chromium-review.googlesource.com/1155125
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579341}
[modify] https://crrev.com/e653e90ca6a59abbeaed25191c27b9a77a788b2b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-transceivers.https.html
[modify] https://crrev.com/e653e90ca6a59abbeaed25191c27b9a77a788b2b/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-transceivers.https-expected.txt

Status: Verified (was: Started)
Labels: Type-Bug

Sign in to add a comment