New issue
Advanced search Search tips

Issue 869035 link

Starred by 1 user
Status: Verified
Owner:
metzman@chromium.org
Closed: Aug 3
Cc:
kcc@chromium.org
mmoroz@chromium.org
mac-bugs-priority@chromium.org
metzman@chromium.org
mbarbe...@chromium.org
infe...@chromium.org
och...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 769578



Sign in to add a comment

libFuzzer Mac build breakage related to LPM

Project Member Reported by mbarbe...@chromium.org, Jul 30 
https://ci.chromium.org/buildbot/chromium.fyi/Libfuzzer%20Upload%20Mac%20ASan/29127

Seems to have been broken by https://chromium.googlesource.com/chromium/src/+/5f2502b0944e416c39e05bea12c04e4258d99d34

Sorry for the delay in catching this one. Too used to seeing the flaky failures from the Mac libFuzzer bots.

Comment 1 by metzman@chromium.org, Jul 30

Status: Started (was: Assigned)
Error is:

[7080/31048] LIBTOOL-STATIC obj/third_party/libprotobuf-mutator/libprotobuf_full.a
FAILED: obj/third_party/libprotobuf-mutator/libprotobuf_full.a 
export DEVELOPER_DIR=/b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app;  rm -f obj/third_party/libprotobuf-mutator/libprotobuf_full.a && TOOL_VERSION=1519173702 python ../../build/toolchain/mac/filter_libtool.py libtool -static  -o obj/third_party/libprotobuf-mutator/libprotobuf_full.a -filelist obj/third_party/libprotobuf-mutator/libprotobuf_full.a.rsp
fatal error: /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file list file: obj/third_party/libprotobuf-mutator/libprotobuf_full.a.rsp is empty


Haven't looked into what is causing this much, do you have any idea Marty?
I've thought of a quick workaround to prevent building of any targets that depend on fuzzable_proto_libraries but this strikes me as non-ideal if we actually think non-Mac specific fuzzers benefit from being fuzzed on Mac. WDYT?

Comment 2 by metzman@chromium.org, Jul 30

Blocking: 769578

Comment 3 by mbarbe...@chromium.org, Jul 30 

Discussed offline but just for posterity the solution we decided on was to disable the LPM-based fuzzers on non-linux platforms.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a2461fa32205e7848d4abf1afabcb847089218

commit 39a2461fa32205e7848d4abf1afabcb847089218
Author: Jonathan Metzman <metzman@chromium.org>
Date: Mon Jul 30 19:50:05 2018

[LPM] Speculative fix for ClusterFuzz Mac build bot breakage

Don't do ClusterFuzz builds of targets dependant on fuzzable_proto_library when not on Linux.

Bug:  869035 , 769578
Change-Id: Ic872263c117a2ef63ab4552d0b5d9f200311aed0
Reviewed-on: https://chromium-review.googlesource.com/1155485
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579127}
[modify] https://crrev.com/39a2461fa32205e7848d4abf1afabcb847089218/third_party/libprotobuf-mutator/fuzzable_proto_library.gni

Comment 6 by metzman@chromium.org, Aug 3

Status: Verified (was: Started)
I probably won't try to get this working because I don't think having this on Mac is beneficial enough to justify the cost and the work to get it working will be considerable since I don't have a mac to test things with.

Comment 7 by metzman@chromium.org, Aug 3 

So for now, I am satisfied with my workaround that disables this feature on Mac.
►

Sign in to add a comment