New issue
Advanced search Search tips

Issue 868992 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.3%-24.5% regression in system_health.memory_desktop at 578830:578914

Project Member Reported by pmeenan@chromium.org, Jul 30

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=868992

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=89d2f08229b64be5a8044069bb2c7275a0cebbb21fcc3114bc2888013a7505bb


Bot(s) for this bug's original alert(s):

linux-perf
Cc: fmalita@chromium.org
Owner: fmalita@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16190e4ba40000

Remove SK_SUPPORT_LEGACY_TEXT_BLOB by fmalita@chromium.org
https://chromium.googlesource.com/chromium/src/+/1f3c291349fb2cc932858a3ea6ff41e691fa05df
2.442e+05 → 3.028e+05 (+5.858e+04)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: herb@google.com
Herb, did we expect this switch to increase memory pressure?
Yes. But probably not this much. How can I learn more about these tests? It
seems like about 100K increase in all of them
Cc: -pmeenan@chromium.org perezju@chromium.org
+perezjs who owns the benchmark according to the sheet: https://docs.google.com/spreadsheets/d/1xaAo0_SU3iDfGdqDJZX_jRV0QtkufwHUKH3kQKF3YQs/edit#gid=0

More info on the system health tests: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark/harnesses/system_health.md
Some more info on memory specific side of things:
https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

Also it's usually a good idea to have a look and compare a couple of traces before/after your change. These are from the perf dashboard on the larger regression:

Before:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/load_news_cnn_2018-07-27_19-48-34_72073.html

After:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/load_news_cnn_2018-07-28_00-17-27_99545.html

In this example the growth seems to come from some skia > sk_glyph_cache > CNN_Sans_Display_* fonts.
skia.png
167 KB View Download
Components: Speed>Metrics>SystemHealthRegressions
Components: -Speed>Metrics>SystemHealthRegressions
Cc: chiniforooshan@chromium.org
 Issue 871256  has been merged into this issue.
 Issue 871368  has been merged into this issue.
 Issue 871855  has been merged into this issue.
Status: WontFix (was: Assigned)
This is working as intended. It is part of a larger change to make the glyph cache multi-threaded.

Sign in to add a comment