New issue
Advanced search Search tips

Issue 868959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 641877



Sign in to add a comment

[css-properties-values-api] Support interpolation of lists.

Project Member Reported by andruud@chromium.org, Jul 30

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22966a730eaf45a03d9dbfecd9b0188892442fe9

commit 22966a730eaf45a03d9dbfecd9b0188892442fe9
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Aug 16 16:54:40 2018

Use base::RepeatingCallback in ListInterpolationFunctions.

In order to implement interpolation types for custom property lists
( issue 868959 ), it is needed to pass along additional state to these
callbacks. Hence, regular function pointers are not enough.

In preparation of that, this CL changes the function pointers to base::
RepeatingCallbacks.

R=flackr@chromium.org

Bug:  868959 
Change-Id: Ic6214d4119af69c9bc1b87a9fdc63c05ea33e05f
Reviewed-on: https://chromium-review.googlesource.com/1165545
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583692}
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/css_image_list_interpolation_type.cc
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/css_length_list_interpolation_type.cc
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/css_shadow_list_interpolation_type.cc
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/css_size_list_interpolation_type.cc
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/list_interpolation_functions.cc
[modify] https://crrev.com/22966a730eaf45a03d9dbfecd9b0188892442fe9/third_party/blink/renderer/core/animation/list_interpolation_functions.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b521675a9d65d599e5d243384b8fe08287a4c813

commit b521675a9d65d599e5d243384b8fe08287a4c813
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Tue Sep 18 16:58:25 2018

[css-properties-values-api] Implement interpolation for custom lists.

This adds a new CSSCustomListInterpolationType, which is to be used for
all custom property lists, regardless of their syntax.

CSSCustomListInterpolationType takes an inner CSSInterpolationType,
which handles the operations on the items inside the list.

R=flackr@chromium.org

Bug:  868959 
Change-Id: I9e77e6c2332569e3cbafa492022144850b5d11db
Reviewed-on: https://chromium-review.googlesource.com/1165546
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592080}
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-angle-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-angle-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-color-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-color-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-integer-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-integer-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-percentage-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-length-percentage-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-number-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-number-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-percentage-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-percentage-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-resolution-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-resolution-list-type-interpolation.html
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-time-list-type-interpolation-expected.txt
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/WebKit/LayoutTests/animations/custom-properties/custom-time-list-type-interpolation.html
[modify] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/BUILD.gn
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/css_custom_list_interpolation_type.cc
[add] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/css_custom_list_interpolation_type.h
[modify] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/css_interpolation_type.h
[modify] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/css_interpolation_types_map.cc
[modify] https://crrev.com/b521675a9d65d599e5d243384b8fe08287a4c813/third_party/blink/renderer/core/animation/list_interpolation_functions_test.cc

Status: Fixed (was: Started)

Sign in to add a comment