New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868945 link

Starred by 1 user
Status: Verified
Owner:
justincohen@chromium.org
Closed: Aug 22
Cc:
mard...@chromium.org
marq@chromium.org
stkhapugin@chromium.org
gambard@chromium.org
pinkerton@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Fake and real omnibox are displayed in landscape NewTabPage when Default Search Engine is not Google.

Project Member Reported by srikanthg@chromium.org, Jul 30 
App Version: 69.0.3497.21 beta
iOS Version: 12.0 beta#4, 11.4.1, 10.3.3
Device: iPhoneX, iPhone7 plus

Steps to reproduce:
  1. Launch Google Chrome
  2. Change the default search engine to Yahoo (anything other than Google)
  3. Open a new tab
  4. Rotate the device to Landscape

Observed results: Two omniboxes are displayed

Expected results: Only real omnibox should be displayed in landscape mode.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: 
Bug reproducible on Safari/Firefox: Firefox: , Safari: 

Link to video/image: https://drive.google.com/file/d/1eBu71NrDX7SygggQ4Jd0UWWWWerjA-2s/preview

Comment 1 by pkl@chromium.org, Jul 30

Cc: rohitrao@chromium.org
Labels: M-69
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
=> stkhapugin because it is omnibox.

Comment 2 by pkl@chromium.org, Jul 30

Labels: Q2

Comment 3 by gambard@chromium.org, Jul 31

Cc: stkhapugin@chromium.org marq@chromium.org
Owner: justincohen@chromium.org
I don't think this should be p1. marq@, can you weight in?

Comment 4 by pkl@chromium.org, Jul 31

Cc: mard...@chromium.org
+mardini who may have an opinion

Comment 5 by fgor...@chromium.org, Jul 31

Labels: zine-triaged

Comment 6 by mard...@chromium.org, Aug 1

Cc: pinkerton@chromium.org
Labels: -Pri-1 Pri-2
I am downgrading this to P2. We want it for M69 but we don't *need* it for M69. Please let me know if you disagree.

Comment 7 by ghendel@google.com, Aug 6

Labels: -Pri-2 -M-69 M-70 Pri-1
Moving to P1 for M-70

Comment 8 by ghendel@google.com, Aug 7

Labels: -Q2

Comment 9 by justincohen@chromium.org, Aug 18

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa86de886891c98e57269fe9cd5af8fc35fd0cae

commit fa86de886891c98e57269fe9cd5af8fc35fd0cae
Author: Justin Cohen <justincohen@google.com>
Date: Wed Aug 22 03:14:28 2018

[ios] Fix NTP landscape omnibox with alternate search engine.

Followup to crbug.com/848762, which had too broad of a fix.

This narrows the scope of the fix to RxR size class only.

Bug: 848762,  868945 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic72760d395eea7aadc32560133c0885657852bcc
Reviewed-on: https://chromium-review.googlesource.com/1183561
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584951}
[modify] https://crrev.com/fa86de886891c98e57269fe9cd5af8fc35fd0cae/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Comment 11 by justincohen@chromium.org, Aug 22

Status: Fixed (was: Started)

Comment 12 by srikanthg@chromium.org, Aug 23

Status: Verified (was: Fixed)
Verified in M70.0.3531.0 canary
iPhoneX, iOS12.0 beta#9
iPhone7 plus, iOS10.3.3

NTP is looking good in Landscape mode with the DSE is not Google.
►

Sign in to add a comment