New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 868923



Sign in to add a comment

Remove Child to Parent relationship in SurfaceReference

Project Member Reported by akaba@google.com, Jul 30

Issue description

Child to Parent relationship is not needed in SurfaceReference, in fact it's not being used anywhere expect in SurfaceManager, so it's safe to remove.
This is a required change for https://bugs.chromium.org/p/chromium/issues/detail?id=868923

 
Status: Assigned (was: Untriaged)
Owner: akaba@chromium.org
Status: WontFix (was: Assigned)
Status: Assigned (was: WontFix)
Why not?
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426325e519c0035e43789e6ef0b16616cf094d7e

commit 426325e519c0035e43789e6ef0b16616cf094d7e
Author: akaba <akaba@google.com>
Date: Thu Aug 02 21:04:23 2018

Remove Child to Parent relationship in SurfaceReference

This CL removes Child to Parent relationship is in SurfaceReference as
a cleanup step toward making Viz more clean and efficient.
This relationship is not contributing to any logic so it's safe to be
removed.

Bug:  868925 , 869444 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I458ca17de868ef31eada09b5ff23c09c13c22523
Reviewed-on: https://chromium-review.googlesource.com/1155095
Commit-Queue: Andre Kaba <akaba@google.com>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580316}
[modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/surfaces/surface_manager.h

Status: Fixed (was: Assigned)

Sign in to add a comment