CSS Scroll Snap properties support quirky length but shouldn't |
|||
Issue descriptionSome web-platform-tests have regressed between M68 and M69: https://wpt.fyi/results/quirks/unitless-length?product=chrome-68&product=chrome-69&diff=true The test in question is excluded-properties.html written by ericwilligers@. It still passes in LayoutTests, but bisecting using Chrome I got to this range: https://chromium.googlesource.com/chromium/src/+log/b1cc586e5eb0c92bbb0c526609374f20e0dda4d2..2f1bec8fbac2adf64ef308ccabcd0481201f6c03 Suspecting this change: https://chromium.googlesource.com/chromium/src/+/f13ce426d1f2ac45ca5bd2b8c728d8832d9598c0 The reason it has regressed is presumably that these properties weren't supported at all before, and have supported unitless lengths from the beginning. Still, if the test is correct, it'd be best to match the spec when shipping. It's not obvious why it isn't also failing in layout tests, possibly because some other experimental web platform feature changing the behavior?
,
Jul 30
http://web-platform-tests.live/quirks/unitless-length/excluded-properties.html verified to fail in Chrome 69.0.3493.3 on Mac, 69.0.3497.12 on Windows, and Linux was the OS I did the bisect on, but with Chromium builds then.
,
Jul 30
Oops, this test was added in https://chromium-review.googlesource.com/1144991 together with the fix. It only seemed like a regression because we were comparing Chrome stable to Chrome dev. We had the test already in web-platform-tests, but the changes hadn't reached Chrome dev yet. |
|||
►
Sign in to add a comment |
|||
Comment 1 by gov...@chromium.org
, Jul 30