New issue
Advanced search Search tips

Issue 868901 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Adaptive Toolbar: Reduce toolbar height when the toolbar is minimized in fullscreen

Project Member Reported by gambard@chromium.org, Jul 30

Issue description

To pschaffner@ to give me specs.
 
Cc: mard...@chromium.org pinkerton@chromium.org marq@chromium.org
Labels: M-69
After checking this with Pete, we will reduce the toolbar height to 20pt in fullscreen (10pt less than the current one).
Owner: gambard@chromium.org
Status: Started (was: Assigned)
Cc: pschaffner@chromium.org stkhapugin@chromium.org
 Issue 861771  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/776ec84b76b241278a98e8f593820b056c84376a

commit 776ec84b76b241278a98e8f593820b056c84376a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Aug 01 14:06:12 2018

Adjust toolbar height in fullscreen

This CL adjusts the toolbar height in fullscreen.
It also adjusts the vertical position of the location bar, in fullscreen
and outside of fullscreen. This is needed to have something which looks
visually balanced.

Bug:  868901 , 865820
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8da381737b4660554a5fb68a213b99860f117d0
Reviewed-on: https://chromium-review.googlesource.com/1156602
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579793}
[modify] https://crrev.com/776ec84b76b241278a98e8f593820b056c84376a/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/776ec84b76b241278a98e8f593820b056c84376a/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/776ec84b76b241278a98e8f593820b056c84376a/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/776ec84b76b241278a98e8f593820b056c84376a/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/776ec84b76b241278a98e8f593820b056c84376a/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm

Labels: Merge-TBD
Cc: kariahda@chromium.org
Labels: -Merge-TBD Merge-Request-69
Status: Verified (was: Started)
Verified on Canary.
+kariahda@ for merge approval.
Labels: -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76f229ad9f6c26ce94befe9e0a682fdc731ee14

commit f76f229ad9f6c26ce94befe9e0a682fdc731ee14
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 02 18:16:29 2018

Adjust toolbar height in fullscreen

This CL adjusts the toolbar height in fullscreen.
It also adjusts the vertical position of the location bar, in fullscreen
and outside of fullscreen. This is needed to have something which looks
visually balanced.

Bug:  868901 , 865820
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8da381737b4660554a5fb68a213b99860f117d0
Reviewed-on: https://chromium-review.googlesource.com/1156602
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579793}(cherry picked from commit 776ec84b76b241278a98e8f593820b056c84376a)
Reviewed-on: https://chromium-review.googlesource.com/1160904
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#342}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/f76f229ad9f6c26ce94befe9e0a682fdc731ee14/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/f76f229ad9f6c26ce94befe9e0a682fdc731ee14/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/f76f229ad9f6c26ce94befe9e0a682fdc731ee14/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/f76f229ad9f6c26ce94befe9e0a682fdc731ee14/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/f76f229ad9f6c26ce94befe9e0a682fdc731ee14/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm

Sign in to add a comment