New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete build/android/play_services/* in favour of android_deps

Project Member Reported by wnwen@chromium.org, Jul 30

Issue description

Remove the upstream scripts that used to fetch android deps and use android_deps scripts here exclusively: https://chromium.googlesource.com/chromium/src/+/master/tools/android/roll/android_deps/README.md

Also add docs for updating play services that are now under android_deps.

Improve licensing
 
Cc: jbudorick@chromium.org
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a3b2361993826c8db98ce4499b73d6763e791b

commit e8a3b2361993826c8db98ce4499b73d6763e791b
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Aug 15 13:47:22 2018

Android: Remove build/secondary/.../support

All of these targets are now in android_deps and aliased there. No need
to keep these duplicate .info files and BUILD.gn file.

Bug:  868879 
Change-Id: Ie449b546328486072d00a319b681cd7512b8ea5a
Reviewed-on: https://chromium-review.googlesource.com/1173061
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583235}
[modify] https://crrev.com/e8a3b2361993826c8db98ce4499b73d6763e791b/build/config/android/config.gni
[modify] https://crrev.com/e8a3b2361993826c8db98ce4499b73d6763e791b/build/secondary/third_party/android_tools/BUILD.gn
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/BUILD.gn
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_arch_lifecycle_runtime_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_animated_vector_drawable_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_cardview_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_compat_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_core_ui_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_core_utils_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_design_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_fragment_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_media_compat_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_multidex_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_transition_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v13_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v14_preference_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v17_leanback_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v17_preference_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_appcompat_java_internal.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_gridlayout_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_mediarouter_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_palette_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_preference_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_v7_recyclerview_java.info
[delete] https://crrev.com/d7bc2a6b1add90f98780c35d169928a3440c9e32/build/secondary/third_party/android_tools/support/android_support_vector_drawable_java.info

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ab1274bbd46073cdbfd897f17dbacbadda4fce

commit f4ab1274bbd46073cdbfd897f17dbacbadda4fce
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Aug 20 15:19:35 2018

Android: Include third-party sub-licenses in deps

GMSCore API libraries now ship their own third party licenses. We append
these licenses to the Android SDK license for each package in order to
ensure that they are all present in our releases.

Bug:  868879 
Change-Id: Ib169e7cbb4c67a1f6a34b11dfe1502fcf4d4155e
Reviewed-on: https://chromium-review.googlesource.com/1159323
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584449}
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_auth/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_base/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_basement/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_cast/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_cast_framework/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_clearcut/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_flags/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_gcm/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_iid/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_instantapps/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_location/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_phenotype/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_places_placereport/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_stats/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_tasks/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_vision/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/third_party/android_deps/libs/com_google_android_gms_play_services_vision_common/LICENSE
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/tools/android/roll/android_deps/build.gradle
[modify] https://crrev.com/f4ab1274bbd46073cdbfd897f17dbacbadda4fce/tools/android/roll/android_deps/fetch_all.py

Labels: DevX
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7899e08d3eafd91c8feba31e2a18b715f833675f

commit 7899e08d3eafd91c8feba31e2a18b715f833675f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 16 15:45:58 2019

Android: Remove build/android/play_services

We have already migrated upstream to third_party/android_deps so these
files and related buildsteps are no longer needed.

This CL also removes the [y/n] confirmation for the Play SDK.

Bug:  877957 , 868879 
Change-Id: I6bdb5355031a2d3a4a9a2f82531bd1956f288edd
Reviewed-on: https://chromium-review.googlesource.com/c/1394925
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623249}
[modify] https://crrev.com/7899e08d3eafd91c8feba31e2a18b715f833675f/DEPS
[modify] https://crrev.com/7899e08d3eafd91c8feba31e2a18b715f833675f/build/android/PRESUBMIT.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/LICENSE.sha1
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/config.json
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/google_play_services_library.zip.sha1
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/update.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/build/android/play_services/update_test.py
[delete] https://crrev.com/ae5e5a5785d23ad6ca824b1ff399fe31b9060b77/tools/android/roll/update_support_library.py

Comment 7 by wnwen@google.com, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment