New issue
Advanced search Search tips

Issue 868878 link

Starred by 2 users
Status: Fixed
Owner:
tikuta@chromium.org
Closed: Dec 20
Cc:
tikuta@chromium.org
seanmccullough@chromium.org
dpranke@chromium.org
martiniss@chromium.org
nedngu...@google.com
jbudorick@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on: View detail
issue 825418
issue 867535
issue 894045


Sign in to add a comment

Receiving webkit_layout_tests result step is slow

Project Member Reported by tikuta@chromium.org, Jul 30 
In below builds, longest shards for webkit_layout_tests ended in 21:19:39 (JST), but webkit_layout_tests (with patch) step started in 21:32:46 (JST) and ended in 21:36:55 (JST).
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/49881

So it looks to take bit long time in receiving or waiting swarming result.
I wonder why this step took such a long time (more than 4 mins) even after the end of test execution on swarming shards.

Comment 2 by jbudorick@chromium.org, Jul 31 

I'm wondering if it just takes us a while to get to collecting the layout tests b/c we're collecting browser_tests etc -- i.e., perhaps this could be improved by https://bugs.chromium.org/p/chromium/issues/detail?id=828937

Comment 3 by martiniss@chromium.org, Jul 31 

This looks like it's the bad collect ordering.

I think the 4 minutes spent in the step are divided between about 3 minutes downloading all the stdout and isolates, and 30 seconds in the merge script.

I think there was the idea to not download the stdout for these builds? That could save us some time here.

I'm going to look into the collect ordering again, which should at least make this type of issue not affect overall build time as much.

Comment 4 by tikuta@chromium.org, Jul 31 

Optimizing collect ordering sounds nice.
But webkit_layout_tests often become the slowest test. So we won't hide this long duration effectively by changing the ordering of collecting.

If it took time for downloading stdout and we can stop that, that can be best solution for this issue.

Comment 5 by martiniss@chromium.org, Jul 31 

It will save us some time, but yes, not all of the time we are theoretically losing.

https://crbug.com/867535 is a bug which talks about not downloading stdout. I'm happy to make this change, want a few more people to buy into the idea before doing so.

Comment 6 by bpastene@chromium.org, Aug 1

Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
Assigning to martiniss based on #3

Comment 7 by tikuta@chromium.org, Aug 1

Blockedon: 867535
I hope stopping stdout download makes the step faster.

Comment 8 by mar...@chromium.org, Aug 1 

Not downloading unneeded task output files would help a lot in the case of layout tests. The recipe shouldn't have to download the files at all.

Comment 10 by tikuta@chromium.org, Oct 31 

#8,

Does webkit_layout_tests really download unnecessary task output files?
Downloaded files seems to be archived in following 'archive results for webkit_layout_tests (with patch)' step.

If we only need to download output.json or some few other files, filtering output will improve the time of this step largely.
https://chromium-review.googlesource.com/c/infra/luci/client-py/+/1309276/

Comment 11 by mar...@chromium.org, Oct 31

Cc: seanmccullough@chromium.org
This whole "downloads from isolated then uploads again" needs to go.
I thought there was a tracking bug but I failed to find it.
cc'ing Sean in case he knows.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f4db0c40df7d6e6670e8cf754e463796474bfb8d

commit f4db0c40df7d6e6670e8cf754e463796474bfb8d
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Nov 01 21:03:42 2018

[client] Increase worker to download isolate files faster

By increasing parallelism of file download, downloading
webkit_layout_tests task outputs improved from 9 minutes to 3 minutes on
my Z840 Linux.

I hope this does some mitigation for slow webkit_layout_tests step.

If this made performance bad on bots, I will revert this patch.

Bug: 868878
Change-Id: I89cdc48bb3c5b4184699f041f1d037963090cd49
Reviewed-on: https://chromium-review.googlesource.com/c/1309854
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/f4db0c40df7d6e6670e8cf754e463796474bfb8d/client/tests/threading_utils_test.py
[modify] https://crrev.com/f4db0c40df7d6e6670e8cf754e463796474bfb8d/client/utils/threading_utils.py
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/91d859f8648e71ca272b2454276fe4667cf11ecc

commit 91d859f8648e71ca272b2454276fe4667cf11ecc
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Nov 02 04:13:49 2018

Revert "[client] Increase worker to download isolate files faster"

This reverts commit f4db0c40df7d6e6670e8cf754e463796474bfb8d.

Reason for revert: This looks not improve the performance on bots.

Original change's description:
> [client] Increase worker to download isolate files faster
> 
> By increasing parallelism of file download, downloading
> webkit_layout_tests task outputs improved from 9 minutes to 3 minutes on
> my Z840 Linux.
> 
> I hope this does some mitigation for slow webkit_layout_tests step.
> 
> If this made performance bad on bots, I will revert this patch.
> 
> Bug: 868878
> Change-Id: I89cdc48bb3c5b4184699f041f1d037963090cd49
> Reviewed-on: https://chromium-review.googlesource.com/c/1309854
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=maruel@chromium.org,martiniss@chromium.org,tikuta@chromium.org

Change-Id: I9e49166b9a69bbdfdc35d54f6847b2ef8a7e58d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878
Reviewed-on: https://chromium-review.googlesource.com/c/1314228
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/91d859f8648e71ca272b2454276fe4667cf11ecc/client/tests/threading_utils_test.py
[modify] https://crrev.com/91d859f8648e71ca272b2454276fe4667cf11ecc/client/utils/threading_utils.py

Comment 14 by tikuta@chromium.org, Nov 6 

This is POC of how we can make webkit_layout_tests step faster if we don't download output files for each test cases.
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/123205

In the build, webkit_layout_tests step took 1m17s, that is much faster than usual 7~8 mins step time.

But layout_test_results is not shown correctly in 'archive results for webkit_layout_tests' step.

Also I'm not much sure why downloading the files on windows bots are slower than linux.
This needs some more investigation by break down actual slow part.

Comment 15 by tikuta@chromium.org, Nov 6

Components: Blink>Infra
If CQ users rarely need the result of webkit layout tests except unexpected failure case, we can stop writing test outputs in webkit test script other than unexpected failure and webkit_layout_tests step will be faster.

martiniss@, if you don't have a time for this issue, can I do above strategy?

Comment 16 by tikuta@chromium.org, Nov 6

Cc: nednguyen@chromium.org

Comment 17 by nedngu...@google.com, Nov 6

Cc: -nednguyen@chromium.org nedngu...@google.com
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/8c72886a52713f1b46f6e672be984d6d7411ef75

commit 8c72886a52713f1b46f6e672be984d6d7411ef75
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Nov 06 20:42:43 2018

[client] Add --filepath-filter option to choose download files from isolate

If I use this option like below, downloading subset files of
webkit_layout_tests become 3 seconds.
That is much faster than 9 min to download all isolate outputs.

$ time tools/swarming_client/swarming.py collect -S
https://chromium-swarm.appspot.com --json task.json
--task-output-dir=tmp --task-summary-json=summary.json
--task-output-stdout=none --filepath-filter='^output.json$'
vm78-m9: 40e16cc5f27bcf10 0
vm222-m9: 40e16cb0049b4510 0
vm419-m1: 40e16cabf8539210 0
vm1405-m4: 40e16cae4b766f10 0
vm1456-m4: 40e16cb5e008a610 0
vm311-m4: 40e16cba51a68b10 0
vm180-m9: 40e16caa5ed5e210 0
vm131-m4: 40e16cb895348610 0
vm458-m4: 40e16cbda53f2910 0
vm91-m4: 40e16cc0a9655a10 0
vm449-m4: 40e16cc986923010 0
vm49-m4: 40e16cc43c95f010 0

real    0m3.497s
user    0m1.549s
sys     0m0.592s

Bug: 868878, 898216
Change-Id: I8f264bd263373241e48438426b623e89b3cf544e
Reviewed-on: https://chromium-review.googlesource.com/c/1309855
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/8c72886a52713f1b46f6e672be984d6d7411ef75/client/isolateserver.py
[modify] https://crrev.com/8c72886a52713f1b46f6e672be984d6d7411ef75/client/swarming.py
[modify] https://crrev.com/8c72886a52713f1b46f6e672be984d6d7411ef75/client/tests/swarming_test.py

Comment 19 by dpranke@chromium.org, Nov 7 

7-8 minutes seems *really* slow; even 1 minutes seems really slow. 

How big are these files these days? Do we have any idea what is taking so long? Are we trying to download N files rather than a single zip file, etc. ?

Comment 20 by tikuta@chromium.org, Nov 7 

ref: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/123911

> How big are these files these days?

From log of 'archive results for webkit_layout_tests (with patch)', size of downloaded files seems around 112MB.
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930557786700857664/+/steps/archive_results_for_webkit_layout_tests__with_patch_/0/stdout

```
  ...
  ...
  Copying: webaudio\MediaStreamAudioSource\mediastreamaudiosourcenode-stderr.txt
  linking C:\b\s\w\ir\kitchen-workdir\layout-test-results\webaudio\MediaStreamAudioSource\mediastreamaudiosourcenode-stderr.txt -> C:\b\s\w\ir\cache\chrome_staging\layout-test-results\webaudio\MediaStreamAudioSource\mediastreamaudiosourcenode-stderr.txt
  Took 7.612000 seconds to create archive directory.
  "C:\Program Files\7-Zip\7z.exe" a -y -mx1 C:\b\s\w\ir\cache\chrome_staging\layout-test-results.zip layout-test-results
  7-Zip [64] 16.04 : Copyright (c) 1999-2016 Igor Pavlov : 2016-10-04
  Scanning the drive:
  2955 folders, 16215 files, 117437611 bytes (112 MiB)
  Creating archive: C:\b\s\w\ir\cache\chrome_staging\layout-test-results.zip
  Items to compress: 19170
  Files read from disk: 16215
  Archive size: 39308837 bytes (38 MiB)
```

But size itself seems not root cause, because only few seconds were taken to upload 38MB zipped file to GCS in archive step.

> Do we have any idea what is taking so long?

I don't. I'd like to investigate the slowness on my windows machine.
The step itself is not fast on linux builder (around 3mins), but windows is much worse than linux.
So the step has slowness of step itself and windows specific one.

> Are we trying to download N files rather than a single zip file, etc. ?

Seems so. And creating single archive file in shards and extract that to merge in builder may help.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/517ed5394845ab8ed99c1e662b6d4917111bea13

commit 517ed5394845ab8ed99c1e662b6d4917111bea13
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Nov 09 21:50:20 2018

[swarming] Add a flag to specify the number of workers

This CL add a flag to configure number of workers downloading isolated files.
By using higher number of workers, we can speed up task collection.

If I run collect for webkit_layout_tests like below, this CL can make collection 3.5x faster.

$ curl https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0 | \
  jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > go.json

$ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=none -output-dir tmp -requests-json go.json
real    2m37.923s
user    1m1.154s
sys     0m16.165s

$ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=none -output-dir tmp -requests-json go.json -worker 50
real    0m45.445s
user    1m12.472s
sys     0m22.671s

Bug: 894045, 868878
Change-Id: I796025bb438f35d5cb6d660417013d890ed385f7
Reviewed-on: https://chromium-review.googlesource.com/c/1329382
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/517ed5394845ab8ed99c1e662b6d4917111bea13/client/cmd/swarming/common.go
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/516b50f758f4d6ffb027cc122810147035b1dc00

commit 516b50f758f4d6ffb027cc122810147035b1dc00
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed Nov 14 16:37:30 2018

[isolate] Increase max_concurrent_requests

When I run `swarming collect` for webkit_layout_tests having large number of task outputs with several hundred parallel download request, I see the request latency, time for Client.Do, to isolateserver become slower and slower during the execution.
At first, I thought this is due to limited resource of local machine or machine resource is not utilized well. But I'm suspecting this is due to lower max_concurrent_requests now.
Due to limited max_concurrent_requests, large number of download requests are throttled by AppEngine.

Currently, we use F4 instance having 4 times more memory than F1. So let me increase this parameter to 30 from default 10.
If I see less memory usage than limit with this change, I will increase this parameter more.

ref:
https://cloud.google.com/appengine/docs/standard/python/config/appref#scaling_elements
https://cloud.google.com/appengine/docs/standard/#instance_classes

Bug: 868878
Change-Id: I2063a8f926318c1aa9e366ed97a838a84cfd34f3
Reviewed-on: https://chromium-review.googlesource.com/c/1335708
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/516b50f758f4d6ffb027cc122810147035b1dc00/appengine/isolate/app.yaml

Comment 23 by tikuta@chromium.org, Nov 15

Cc: tikuta@chromium.org
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/2ee324fb6b887003cdafb128f19494204b01b053

commit 2ee324fb6b887003cdafb128f19494204b01b053
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Nov 20 04:34:50 2018

[swarming] Introduce conccurentHTTP2 RoundTripper

This change makes large number of concurrent http2 request scalable.

Golang's http2.Transport blocks requests if the number of concurrent request reached maxConcurrentStreams (default 1000).
ref: https://github.com/golang/go/issues/13774

And this becomes limiting factor when we download isolated outputs for webkit_layout_test that requires more than 20000 http requests to isolateserver.

With this change, collect from a webkit_layout_test results took 16.4 seconds.
$ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
$ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
$ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
     -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json

real    0m16.420s
user    0m36.004s
sys     0m11.293s


Without this change, it took 44.5 seconds.
$ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
$ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
$ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
     -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json

real    0m44.514s
user    1m38.394s
sys     0m47.534s

Bug: 868878
Change-Id: Icc874a120526146f25c38b7f2f5040c9b09542c0
Reviewed-on: https://chromium-review.googlesource.com/c/1337186
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/2ee324fb6b887003cdafb128f19494204b01b053/client/cmd/swarming/collect.go
[modify] https://crrev.com/2ee324fb6b887003cdafb128f19494204b01b053/client/cmd/swarming/main.go
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/dd31ca1c4153c785316a9f95cfa831680ce62efd

commit dd31ca1c4153c785316a9f95cfa831680ce62efd
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Nov 20 10:47:12 2018

Revert "[swarming] Introduce conccurentHTTP2 RoundTripper"

This reverts commit 2ee324fb6b887003cdafb128f19494204b01b053.

Reason for revert: https://logs.chromium.org/logs/chromium/led/tikuta_google.com/a86851c25b9366108e7a827c1a82b58c0c2ec4cb7680e5ab4a3917ca3045f242/+/steps/webkit_layout_tests__with_patch_/0/stdout

[W2018-11-20T02:43:14.307522-08:00 4944 0 auth.go:1268] Failed to mint a token: Post http://127.0.0.1:50843/rpc/LuciLocalAuthService.GetOAuthToken: http2: unsupported scheme {"key":"luci_ctx/7c8168d0224dcee4a98a3bf4286b7409675739d7a24f63a0ae0e01dcbf2a1ab0", "scopes":"https://www.googleapis.com/auth/userinfo.email"}


Original change's description:
> [swarming] Introduce conccurentHTTP2 RoundTripper
> 
> This change makes large number of concurrent http2 request scalable.
> 
> Golang's http2.Transport blocks requests if the number of concurrent request reached maxConcurrentStreams (default 1000).
> ref: https://github.com/golang/go/issues/13774
> 
> And this becomes limiting factor when we download isolated outputs for webkit_layout_test that requires more than 20000 http requests to isolateserver.
> 
> With this change, collect from a webkit_layout_test results took 16.4 seconds.
> $ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
> $ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
> $ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
>      -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json
> 
> real    0m16.420s
> user    0m36.004s
> sys     0m11.293s
> 
> 
> Without this change, it took 44.5 seconds.
> $ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
> $ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
> $ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
>      -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json
> 
> real    0m44.514s
> user    1m38.394s
> sys     0m47.534s
> 
> Bug: 868878
> Change-Id: Icc874a120526146f25c38b7f2f5040c9b09542c0
> Reviewed-on: https://chromium-review.googlesource.com/c/1337186
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=maruel@chromium.org,vadimsh@chromium.org,tikuta@chromium.org

Change-Id: Ib9a228958820db90297ef82603704fa2d47efe96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878
Reviewed-on: https://chromium-review.googlesource.com/c/1343910
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/dd31ca1c4153c785316a9f95cfa831680ce62efd/client/cmd/swarming/collect.go
[modify] https://crrev.com/dd31ca1c4153c785316a9f95cfa831680ce62efd/client/cmd/swarming/main.go

Comment 26 by mar...@chromium.org, Nov 20 

I've restarted working on issue 825418, I feel this is a lower hanging fruit.

Comment 27 by tikuta@chromium.org, Nov 20

Blockedon: 825418
Labels: -Pri-3 Pri-2
Re #c26, Nice!
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/eedd5f1fb3d4f8625e4d2ccc6ee8848ec61d458e

commit eedd5f1fb3d4f8625e4d2ccc6ee8848ec61d458e
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Nov 29 04:25:57 2018

Reland "[swarming] Introduce conccurentHTTP2 RoundTripper"

This is a reland of 2ee324fb6b887003cdafb128f19494204b01b053

I changed to use http.DefaultTransport for non-https request.

Testing the binary performance in
https://chromium-swarm.appspot.com/task?id=4149b9c897329610&refresh=10

In the job, https://chromium-swarm.appspot.com/task?id=4149cdcee053bf10&refresh=10&show_raw=1
completed in 2018-11-20T12:16:14.583030 and webkit_layout_test step ended in
2018-11-20T12:18:01, so actual output collect took less than 2 minutes.

Original change's description:
> [swarming] Introduce conccurentHTTP2 RoundTripper
>
> This change makes large number of concurrent http2 request scalable.
>
> Golang's http2.Transport blocks requests if the number of concurrent request reached maxConcurrentStreams (default 1000).
> ref: https://github.com/golang/go/issues/13774
>
> And this becomes limiting factor when we download isolated outputs for webkit_layout_test that requires more than 20000 http requests to isolateserver.
>
> With this change, collect from a webkit_layout_test results took 16.4 seconds.
> $ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
> $ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
> $ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
>      -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json
>
> real    0m16.420s
> user    0m36.004s
> sys     0m11.293s
>
>
> Without this change, it took 44.5 seconds.
> $ url=https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930326331824041104/+/steps/test_pre_run/0/steps/s__trigger__webkit_layout_tests__with_patch_/0/logs/json.output/0
> $ curl $url | jq '.tasks | to_entries | {"tasks": map(.value | {task_id})}' > ~/go.json
> $ time swarming collect -verbose -server chromium-swarm.appspot.com -task-output-stdout=json \
>      -output-dir tmp -requests-json ~/go.json  -worker 100 -task-summary-json summary.json
>
> real    0m44.514s
> user    1m38.394s
> sys     0m47.534s
>
> Bug: 868878
> Change-Id: Icc874a120526146f25c38b7f2f5040c9b09542c0
> Reviewed-on: https://chromium-review.googlesource.com/c/1337186
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: 868878
Change-Id: I8970bfa795b4491f6ab642a0fd91536985cd9a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1343912
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/eedd5f1fb3d4f8625e4d2ccc6ee8848ec61d458e/client/cmd/swarming/collect.go
[modify] https://crrev.com/eedd5f1fb3d4f8625e4d2ccc6ee8848ec61d458e/client/cmd/swarming/main.go
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28e7f87b9536cd2294b3b34b4e052e407ce71052

commit 28e7f87b9536cd2294b3b34b4e052e407ce71052
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Nov 29 13:39:35 2018

Update luci-go client

Took from this revision.
https://chromium.googlesource.com/infra/infra/+/f140d0c3c6acecf6ca6cd8d66ddad9421158ab40

Bug: 868878, 894045
Change-Id: I0ad0a837b3f1b036611aeca912eade69abb2d1b6
Reviewed-on: https://chromium-review.googlesource.com/c/1354754
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612173}
[modify] https://crrev.com/28e7f87b9536cd2294b3b34b4e052e407ce71052/DEPS

Comment 30 by martiniss@chromium.org, Dec 4

Owner: tikuta@chromium.org
I haven't worked on this in a while, looks like tikuta@ has been.
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba

commit d0a3d72947784d80c6522f9dd1fe8fc109fda5ba
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Dec 06 03:55:30 2018

[swarming] Use go client to collect task

This replaces swarming-py to luci-go client.
* Change some flag names
* Change the way to handle summary json in collect_task.py

This is tested on
$ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
* https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
* https://chromium-swarm.appspot.com/task?id=419859fce0922510

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 868878, 894045
Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
Reviewed-on: https://chromium-review.googlesource.com/c/1333174
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_with_test_spec.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures_flakes.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/README.recipes.md
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_one_failure.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_bisect_tester_swarming.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_positional_extra_flags.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_rel.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic_luci.json
[modify] https://crrev.com/d0a3d72947784d80c6522f9dd1fe8fc109fda5ba/scripts/
Project Member

Comment 32 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d832c5d0d61408972ee2eba563aed35d03ecf741

commit d832c5d0d61408972ee2eba563aed35d03ecf741
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Dec 06 07:35:26 2018

Revert "[swarming] Use go client to collect task"

This reverts commit d0a3d72947784d80c6522f9dd1fe8fc109fda5ba.

Reason for revert: All V8 is purple, e.g.:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/28912

Original change's description:
> [swarming] Use go client to collect task
> 
> This replaces swarming-py to luci-go client.
> * Change some flag names
> * Change the way to handle summary json in collect_task.py
> 
> This is tested on
> $ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
> * https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
> * https://chromium-swarm.appspot.com/task?id=419859fce0922510
> 
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 868878, 894045
> Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
> Reviewed-on: https://chromium-review.googlesource.com/c/1333174
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=maruel@chromium.org,vadimsh@chromium.org,tikuta@chromium.org

Change-Id: I78026a62d8c3169af42e1c60a1411e4034754171
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878, 894045
Reviewed-on: https://chromium-review.googlesource.com/c/1365330
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_with_test_spec.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures_flakes.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/README.recipes.md
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_one_failure.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_bisect_tester_swarming.json
[modify] https://crrev.com/d832c5d0d61408972ee2eba563aed35d03ecf741/scripts/slav

Comment 33 by tikuta@chromium.org, Dec 6 

During go client is live, 50 percentile of webkit_layout_test step improved from 10 mins to around 3 mins. So switching to go client is very promising for this issue.

But p90 is not improved well, this is due to outlier overhead of webkit_layout_tests or long pending time.
d0zapdr4KPE.png
201 KB View Download

Comment 34 by tikuta@chromium.org, Dec 6 

#33, the stats shows win7_chromium_rel_ng builder data only.
Project Member

Comment 35 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/03d836653e6b59d29a6cc46eba8c0b34b06093b0

commit 03d836653e6b59d29a6cc46eba8c0b34b06093b0
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Dec 07 08:50:52 2018

[v8] allow v8 to use python client for swarming

I'd like to migrate swarming go client, but gradually and focus on chromium.
Let me keep v8 uses python client while chromium uses go client for a while.

This is to prevent failure causing this revert
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1365330

Bug: 868878
Change-Id: Ib09b3746cec8e625929fe19a9233b1b04cdb25ac
Reviewed-on: https://chromium-review.googlesource.com/c/1365471
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/03d836653e6b59d29a6cc46eba8c0b34b06093b0/scripts/slave/README.recipes.md
[modify] https://crrev.com/03d836653e6b59d29a6cc46eba8c0b34b06093b0/scripts/slave/recipe_modules/v8/testing.py
[modify] https://crrev.com/03d836653e6b59d29a6cc46eba8c0b34b06093b0/scripts/slave/recipe_modules/swarming/api.py
Project Member

Comment 36 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e74c09c578e601e1984c62362016b96f9329ba70

commit e74c09c578e601e1984c62362016b96f9329ba70
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Dec 07 09:52:22 2018

Reland "[swarming] Use go client to collect task"

This is a reland of d0a3d72947784d80c6522f9dd1fe8fc109fda5ba

This was tested on
$ led get-builder luci.chromium.try:android-marshmallow-arm64-rel | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1364995 | led lunch
https://chromium-swarm.appspot.com/task?id=419bbc7873b24510

I keep to use python client for v8 in
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1365471

Original change's description:
> [swarming] Use go client to collect task
>
> This replaces swarming-py to luci-go client.
> * Change some flag names
> * Change the way to handle summary json in collect_task.py
>
> This is tested on
> $ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
> * https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
> * https://chromium-swarm.appspot.com/task?id=419859fce0922510
>
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 868878, 894045
> Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
> Reviewed-on: https://chromium-review.googlesource.com/c/1333174
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 868878, 894045
Change-Id: I0c7c59e86204cb784bf6b39d4f9767f93e2b36cb
Reviewed-on: https://chromium-review.googlesource.com/c/1365470
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run_skip.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_with_test_spec.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures_flakes.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/README.recipes.md
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_one_failure.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b96f9329ba70/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/e74c09c578e601e1984c62362016b
Project Member

Comment 37 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b59385459f37c8b043546260afd078bcac20a598

commit b59385459f37c8b043546260afd078bcac20a598
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Dec 07 10:35:25 2018

Revert "Reland "[swarming] Use go client to collect task""

This reverts commit e74c09c578e601e1984c62362016b96f9329ba70.

Reason for revert: seems broke v8 bot again
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/28938

Original change's description:
> Reland "[swarming] Use go client to collect task"
> 
> This is a reland of d0a3d72947784d80c6522f9dd1fe8fc109fda5ba
> 
> This was tested on
> $ led get-builder luci.chromium.try:android-marshmallow-arm64-rel | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1364995 | led lunch
> https://chromium-swarm.appspot.com/task?id=419bbc7873b24510
> 
> I keep to use python client for v8 in
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/1365471
> 
> Original change's description:
> > [swarming] Use go client to collect task
> >
> > This replaces swarming-py to luci-go client.
> > * Change some flag names
> > * Change the way to handle summary json in collect_task.py
> >
> > This is tested on
> > $ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
> > * https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
> > * https://chromium-swarm.appspot.com/task?id=419859fce0922510
> >
> > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > Bug: 868878, 894045
> > Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1333174
> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> 
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 868878, 894045
> Change-Id: I0c7c59e86204cb784bf6b39d4f9767f93e2b36cb
> Reviewed-on: https://chromium-review.googlesource.com/c/1365470
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>

TBR=maruel@chromium.org,vadimsh@chromium.org,machenbach@chromium.org,tikuta@chromium.org

Change-Id: I33d57319f5dd22d14072a4fcd11734764ffdc2fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878, 894045
Reviewed-on: https://chromium-review.googlesource.com/c/1367544
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run_skip.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_with_test_spec.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_test_failures_flakes.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/README.recipes.md
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_one_failure.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/b59385459f37c8b043546260afd078bcac20a598/scripts/slave/recipes/webrtc/stan
Project Member

Comment 38 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f80097bd1a9143755415a83425910135a300f132

commit f80097bd1a9143755415a83425910135a300f132
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Dec 10 10:51:15 2018

Reland "Reland "[swarming] Use go client to collect task""

This is a reland of e74c09c578e601e1984c62362016b96f9329ba70

Make get_collect_cmd_args_for_python use trigger_output_python for python client.
Also enforce v8 uses python client always.

v8 is tested in
$ led get-build 8927538925828025520 | led edit-recipe-bundle | led lunch
https://chromium-swarm.appspot.com/task?id=41b0658aa7fc2610

Original change's description:
> Reland "[swarming] Use go client to collect task"
>
> This is a reland of d0a3d72947784d80c6522f9dd1fe8fc109fda5ba
>
> This was tested on
> $ led get-builder luci.chromium.try:android-marshmallow-arm64-rel | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1364995 | led lunch
> https://chromium-swarm.appspot.com/task?id=419bbc7873b24510
>
> I keep to use python client for v8 in
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/1365471
>
> Original change's description:
> > [swarming] Use go client to collect task
> >
> > This replaces swarming-py to luci-go client.
> > * Change some flag names
> > * Change the way to handle summary json in collect_task.py
> >
> > This is tested on
> > $ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
> > * https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
> > * https://chromium-swarm.appspot.com/task?id=419859fce0922510
> >
> > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > Bug: 868878, 894045
> > Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1333174
> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
>
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug: 868878, 894045
> Change-Id: I0c7c59e86204cb784bf6b39d4f9767f93e2b36cb
> Reviewed-on: https://chromium-review.googlesource.com/c/1365470
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>

Bug: 868878, 894045
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: Ie36cdf2d26d7b9e802d87a9188b380ccb13ce4d7
Reviewed-on: https://chromium-review.googlesource.com/c/1367545
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run_skip.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/README.recipes.md
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/v8/testing.py
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/f80097bd1a9143755415a83425910135a300f132/scripts/slave/recipes/ios/try.expected/gn.json
[modify] ht
Project Member

Comment 39 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1606fe382905960f4ca1d76893a2c8dbec18e66d

commit 1606fe382905960f4ca1d76893a2c8dbec18e66d
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Dec 10 12:04:13 2018

Revert "Reland "Reland "[swarming] Use go client to collect task"""

This reverts commit f80097bd1a9143755415a83425910135a300f132.

Reason for revert: broke webrtc builder
https://ci.chromium.org/buildbot/client.webrtc.perf/Win7/7683

Original change's description:
> Reland "Reland "[swarming] Use go client to collect task""
> 
> This is a reland of e74c09c578e601e1984c62362016b96f9329ba70
> 
> Make get_collect_cmd_args_for_python use trigger_output_python for python client.
> Also enforce v8 uses python client always.
> 
> v8 is tested in
> $ led get-build 8927538925828025520 | led edit-recipe-bundle | led lunch
> https://chromium-swarm.appspot.com/task?id=41b0658aa7fc2610
> 
> Original change's description:
> > Reland "[swarming] Use go client to collect task"
> >
> > This is a reland of d0a3d72947784d80c6522f9dd1fe8fc109fda5ba
> >
> > This was tested on
> > $ led get-builder luci.chromium.try:android-marshmallow-arm64-rel | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1364995 | led lunch
> > https://chromium-swarm.appspot.com/task?id=419bbc7873b24510
> >
> > I keep to use python client for v8 in
> > https://chromium-review.googlesource.com/c/chromium/tools/build/+/1365471
> >
> > Original change's description:
> > > [swarming] Use go client to collect task
> > >
> > > This replaces swarming-py to luci-go client.
> > > * Change some flag names
> > > * Change the way to handle summary json in collect_task.py
> > >
> > > This is tested on
> > > $ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led edit-cr-cl https://chromium-review.googlesource.com/c/chromium/src/+/1363730 | led lunch
> > > * https://chromium-swarm.appspot.com/task?id=419859da9066ec10 and
> > > * https://chromium-swarm.appspot.com/task?id=419859fce0922510
> > >
> > > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > > Bug: 868878, 894045
> > > Change-Id: I06273a9be7e9ec9c058bcf4bdb259ac5d7c60d3b
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1333174
> > > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> >
> > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > Bug: 868878, 894045
> > Change-Id: I0c7c59e86204cb784bf6b39d4f9767f93e2b36cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/1365470
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> 
> Bug: 868878, 894045
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Change-Id: Ie36cdf2d26d7b9e802d87a9188b380ccb13ce4d7
> Reviewed-on: https://chromium-review.googlesource.com/c/1367545
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=maruel@chromium.org,vadimsh@chromium.org,machenbach@chromium.org,tikuta@chromium.org

Change-Id: Ib857699406c22db7413f8370cd77b50dcaa9c63a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878, 894045
Reviewed-on: https://chromium-review.googlesource.com/c/1369475
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_invalid_test_results.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/builder_as_tester.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/dart/examples/example.expected/vm-win.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/nonzero_exit_code_no_gtest_output.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/merge.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/basic.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run_skip.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/basic_luci_experimental.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_expired_new.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/swarming_timeout_new.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_arm_dbg.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android64__m_nexus5x_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_long_task.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/xparallel_run.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_android_experimental.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.expected/android.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_initializers.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/v8/flako.expected/full_bisect.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/dart/examples/example.expected/analyzer-none-linux-release-be.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_gcmole.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/README.recipes.md
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/v8/testing.py
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_with_null_shard.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_recipes.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/1606fe382905960f4ca1d76893a2c8dbec18e66d/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modif
Project Member

Comment 40 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8d90a80f1352aaf130ecceefb031c0e23b8bdce9

commit 8d90a80f1352aaf130ecceefb031c0e23b8bdce9
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Tue Dec 11 15:10:53 2018

Reland #4 of "[swarming] Use go client to collect task"

This is a reland of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1367545

Enable go swarming client only in isolated script tests in chromium_test module.

Bug: 868878, 894045
Change-Id: If96fb7fbf6dd51c38c89bca132781a8dc62faf7e
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/c/1369476
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/findit/chromium/test.expected/webkit_layout_tests.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_forced.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/README.recipes.md
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_debug.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_rel.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic_luci.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_android.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg_win10.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_tsan_v2.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg_win8.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_no_results_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac_hidpi.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/swarming/unittests/collect_task_test.py
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_trigger_script.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan_vptr.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_tsan2.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_ignore_task_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_linux_more_configs.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_invalid.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_no_results.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_ignore_task_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_asan.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/fake_results_handler.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_disabled.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_dbg.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan_vptr.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_not_uploading.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/8d90a80f1352aaf130ecceefb031c0e23b8bdce9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
Project Member

Comment 41 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/954c2146df7bdad580c4b3a001a9221eb5002a43

commit 954c2146df7bdad580c4b3a001a9221eb5002a43
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Dec 11 22:35:44 2018

Revert "Reland #4 of "[swarming] Use go client to collect task""

This reverts commit 8d90a80f1352aaf130ecceefb031c0e23b8bdce9.

Reason for revert: crbug.com/914009

Original change's description:
> Reland #4 of "[swarming] Use go client to collect task"
> 
> This is a reland of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1367545
> 
> Enable go swarming client only in isolated script tests in chromium_test module.
> 
> Bug: 868878, 894045
> Change-Id: If96fb7fbf6dd51c38c89bca132781a8dc62faf7e
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Reviewed-on: https://chromium-review.googlesource.com/c/1369476
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

TBR=maruel@chromium.org,machenbach@chromium.org,tikuta@chromium.org,jbudorick@chromium.org

Change-Id: I7e6f2669b3d605aaf810c04b47d8d330c9d1faac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868878, 894045
Reviewed-on: https://chromium-review.googlesource.com/c/1372370
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_release.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_failing_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms_LUCI_missing_perf_dashboard_machine_group_property.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/custom_webkit_tests_step_name.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux32_debug.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/findit/chromium/test.expected/webkit_layout_tests.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_experimental.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/swarming/resources/collect_task.py
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_x86_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_experimental.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_msan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_msvc_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_all_shards.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_win__more_configs_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug_forced.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_msan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_windows.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win64_debug.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_release.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_win_x86_more_configs.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_clang_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_memcheck.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/README.recipes.md
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_max_failures.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_debug.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_debug.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_ci_linux__more_configs_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_passing.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_webkit_layout_tests.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets_plus_optional.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/override_compile_targets.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_disabled.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_on_trybot_failing.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_rel.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/basic_luci.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_android.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg_win10.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux64_debug.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_tsan_v2.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_too_many_failures_for_retcode.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_release__clang_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_mac_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x64_clang_dbg_win8.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_no_results_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/dimensions_mac_hidpi.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/swarming/unittests/collect_task_test.py
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_trigger_script.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_linux_ubsan_vptr.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_tsan2.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_ignore_task_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/more_configs.expected/luci_webrtc_try_linux_more_configs.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_invalid.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_no_results.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_ignore_task_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_win32_asan.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/fake_results_handler.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_disabled.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_win_x86_msvc_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_dbg.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_try_linux_ubsan_vptr.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_unexpected_error.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_ci_mac64_release.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_not_uploading.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_results_handler.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/954c2146df7bdad580c4b3a001a9221eb5002a43/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json

Comment 42 by tikuta@chromium.org, Dec 12

Blockedon: 894045
Project Member

Comment 43 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0

commit 2c506e0dceb7b1c9f9ec5027194760cf6f6234d0
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Dec 13 16:57:25 2018

Reland #5 of "[swarming] Use go client to collect task"

This is a reland of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1369476

fix from previous try in swarming/api.py:
python client exit with non-zero status when swarming task exit with failure, but go client does not.
Let me handle exit status in recipe side for go client.

Also enable go client only for win7_chromium_rel_ng and 'Win7 Tests (1)' this time.

Confirming the behavior in
$ led get-build 8927247050970809440 | led edit-recipe-bundle | led launch
https://chromium-swarm.appspot.com/task?id=41c0ea1f39423910

$ led get-builder luci.chromium.try:win7_chromium_rel_ng | led edit-recipe-bundle | led launch
https://chromium-swarm.appspot.com/task?id=41c1192e28f44510

Bug: 868878, 894045, 914009
Change-Id: I1e93035c07f807fdca7223203ec9871a4e6e2ab9
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/c/1372185
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/chromium_swarming/api.py
[add] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/swarming/examples/full.expected/isolated_script_non_zero_exit_status.json
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/README.recipes.md
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/chromium_swarming/tests/configure_swarming.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/swarming/unittests/collect_task_test.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/swarming/examples/full.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/2c506e0dceb7b1c9f9ec5027194760cf6f6234d0/scripts/slave/recipe_modules/swarming/resources/collect_task.py

Comment 44 by tikuta@chromium.org, Dec 14 

So far, switching is there this time.
I will use this SQL to track the webkit_layout_tests step performance.
https://pantheon.corp.google.com/bigquery?folder&organizationId=433637338589&project=cr-buildbucket&j=bquxjob_c63e509_167ab37795e&page=queryresults

Comment 45 by tikuta@chromium.org, Dec 20

Status: Fixed (was: Assigned)
After the client switch, time of webkit_layout_tests step reduced like below

* average: 600~700 -> 360~430
* p50: 550~600 -> 270~340
* p90: no visible difference

Actual download of output tasks finish around 30 seconds now.

Stats is taken from
https://pantheon.corp.google.com/bigquery?folder&organizationId=433637338589&project=cr-buildbucket&j=bquxjob_379148b7_167ca137687&page=queryresults

Yet slowest steps will be resolved by issue 914104
Or we want to focus on performance improvement of merge script.
ObSYtWGCLXp.png
135 KB View Download
►

Sign in to add a comment