Background Fetch icon choosing logic returns null if optional fields missing |
||
Issue descriptionsrc is the only required field in ImageResource. If any of sizes or purpose are missing (optional fields), no icon is displayed.
,
Sep 23
It's interesting to me. I want to fix this issue!
,
Sep 25
jdragon.bae@, please feel free take it on. :)
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f43982d4c6c5da759eb36af5aef875b55a19a41 commit 6f43982d4c6c5da759eb36af5aef875b55a19a41 Author: Jaeyong Bae <jdragon.bae@gmail.com> Date: Fri Oct 05 17:10:44 2018 Add processing for missing fields in ImageResource If any of sizes or purpose are missing in ImageResource, provide default values for 'purpose' and 'sizes'. Bug: 868875 Change-Id: I2e88144e1d098a18c740ffeaf9a2fb474db031a1 Reviewed-on: https://chromium-review.googlesource.com/c/1244176 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#597175} [modify] https://crrev.com/6f43982d4c6c5da759eb36af5aef875b55a19a41/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc [modify] https://crrev.com/6f43982d4c6c5da759eb36af5aef875b55a19a41/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader_test.cc
,
Oct 15
|
||
►
Sign in to add a comment |
||
Comment 1 by na...@chromium.org
, Aug 7