[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1154644 |
||
Issue descriptionWPT import https://crrev.com/c/1154644 introduced new failures in external/wpt/svg: List of new failures: external/wpt/svg/idlharness.window.html new failing tests: https://crrev.com/c/1154644/4/third_party/WebKit/LayoutTests/external/wpt/svg/idlharness.window-expected.txt This import contains upstream changes from ae6368e7b8fafc7acdd9b6c0d8a31bda95f72c68 to 24c4f1e5c434a5ad018aa7467b7bfcffca764b8d: Update the SVG IDL file + test (#11796): https://github.com/web-platform-tests/wpt/commit/24c4f1e5c434a5ad018aa7467b7bfcffca764b8d [affecting this directory] Find LayoutText containing the first letter before attaching pseudo.: https://github.com/web-platform-tests/wpt/commit/3442f9d9d984af97c015dabbf1e59dde9585cca4 html: Split semantics/tabular-data/processing-model-1/span-limits.html into two.: https://github.com/web-platform-tests/wpt/commit/1e0465e0b37af31c2f261c3cfb3291afa143c1af
,
Aug 14
Lots of stuff going on here - I think we have most of that covered already. There's also stuff that I'm not sure makes any sense to implement (at least ATM), and that in general no one has implemented. https://wpt.fyi/results/svg/idlharness.window.html is slightly easier to sift through BTW. Rough breakdown: SVGElement.prototype.correspondingElement/correspondingUseElement SVGUseElement.prototype.instanceRoot/animatedInstanceRoot SVGUseElementShadowRoot ShadowAnimation "New" <use> related functionality - mostly related to introspection (which we don't allow at all right now.) I'm going to ignore this for now. interface SVGSymbolElement : SVGGraphicsElement (changed from inheriting SVGElement) This change appears to be strongly connected to the point above, so I think we can give it the same treatment for now (i.e ignore.) SVGImageElement.prototype.crossOrigin Issue 842321 SVGScriptElement.prototype.crossOrigin Issue 873982 SVGUnknownElement Seems we have no bug for this - not sure we should be in any rush here. Use of types from the Geometry spec (DOMPoint{,Init}, DOMRect, ...) Covered by issue 709001. A bunch of properties on SVGAElement (aligning with HTMLAnchorElement) Issue 873988 SVGMarkerElement.prototype.orient Issue 873985 It's possible that something slipped (because of the mass of subtests), but it probably doesn't matter much (likely to fall in one of the above categories or be on file already.) There also appears to be a few typos in the test, which I'll try to fix up...
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14c795a4725a2106fd7ded031a8ec9514d9e1daf commit 14c795a4725a2106fd7ded031a8ec9514d9e1daf Author: Fredrik Söderquist <fs@opera.com> Date: Tue Aug 14 17:18:54 2018 Fix element creation in wpt/svg/idlharness.window.js Adjust casing for 'desc', 'switch' and 'mpath'. Remove a duplicate 'animateColor'. BUG= 868861 Change-Id: I19256547abea3028791de402e354c47eee8ce949 Reviewed-on: https://chromium-review.googlesource.com/1174261 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#582955} [modify] https://crrev.com/14c795a4725a2106fd7ded031a8ec9514d9e1daf/third_party/WebKit/LayoutTests/external/wpt/svg/idlharness.window-expected.txt [modify] https://crrev.com/14c795a4725a2106fd7ded031a8ec9514d9e1daf/third_party/WebKit/LayoutTests/external/wpt/svg/idlharness.window.js
,
Aug 15
Considering "fixed"; see c#2 for reasoning. |
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Jul 30Status: Available (was: Untriaged)