New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868823 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chrome OS telemetry control files are not sync to generate_controlfiles.py

Project Member Reported by vovoy@chromium.org, Jul 30

Issue description

After running generate_controlfiles.py, all control files may be modified if they are not sync to generate_controlfiles.py. Syncing control files and generate_controlfiles.py to make future Chrome OS telemetry benchmark modification easier.
 
Cc: hctsai@chromium.org
Every time I run generate_controlfiles.py, a lot of control files are modified, and I have to git checkout these control files before commit. It can be avoided by syncing controls files and generate_controlfiles.py.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/500669f5f7a9b1b5d722e49e3364285ad7b9b839

commit 500669f5f7a9b1b5d722e49e3364285ad7b9b839
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Tue Jul 31 23:37:31 2018

telemetry_Benchmarks: generate_controlfiles.py improvements

Retains the copyright year and author when generating control files.
Checks for unmanaged files.

BUG= chromium:868823 
TEST=running generate_controlfiles.py and check the control files

Change-Id: I187cefb0cc4a1ee15f4d23faa06aa9393c030062
Reviewed-on: https://chromium-review.googlesource.com/1156106
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Vovo Yang <vovoy@chromium.org>

[modify] https://crrev.com/500669f5f7a9b1b5d722e49e3364285ad7b9b839/server/site_tests/telemetry_Benchmarks/control.cros_tab_switching.typical_24
[modify] https://crrev.com/500669f5f7a9b1b5d722e49e3364285ad7b9b839/server/site_tests/telemetry_Benchmarks/control.speedometer2
[modify] https://crrev.com/500669f5f7a9b1b5d722e49e3364285ad7b9b839/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py

Status: Fixed (was: Assigned)

Sign in to add a comment