New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868817 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: ----
Type: ----



Sign in to add a comment

[Tracking bug] Refactor PasswordManagerClient to support optional MetricsRecorder

Project Member Reported by scottwu@chromium.org, Jul 30

Issue description

Metrics recording is not enabled for ios web view. In order to make it optional in current password manager logic, refactor is needed like changing GetMetricsRecorder to return a pointer as well as adding nullptr checking logic.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef922c8f4b3f8efd97b9e92c882a8803830e0d88

commit ef922c8f4b3f8efd97b9e92c882a8803830e0d88
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Aug 03 08:09:01 2018

Refactor PasswordManagerClient to support optional MetricsRecorder.

Metrics recording is not enabled for ios web view. In order to make it optional in current password manager logic, refactor is needed like changing GetMetricsRecorder to return a pointer as well as adding nullptr checking logic.

Bug:  868817 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8a5b7c9a835e72992a04cb15758a4e2ee86d748c
Reviewed-on: https://chromium-review.googlesource.com/1154848
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580475}
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/ef922c8f4b3f8efd97b9e92c882a8803830e0d88/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Status: Fixed (was: Assigned)

Sign in to add a comment