Long Press InProduct help isn't displayed when opening a new tab from the TabGrid |
||||
Issue descriptionEnable "In-Product Help Demo Mode -> IPH_LongPressToolbarTip" from chrome://flags What steps will reproduce the problem? (1) Open the tab grid (2) Tap the "+" button to open a new tab What is the expected result? The in product help should be displayed. What happens instead? Nothing.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e96f4580f8f04adc4e5e8a2e3cb33230e67c7f3 commit 0e96f4580f8f04adc4e5e8a2e3cb33230e67c7f3 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Jul 30 16:12:55 2018 Present the InProductHelp when using the TabGrid This CL adds a trigger to the InProductHelp for the LongPress menu when a new Tab is opened from the TabGrid. Bug: 868789 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1fb6b128a4fc59c6f6c349f4cbe01d9c64bf94bf Reviewed-on: https://chromium-review.googlesource.com/1154908 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579058} [modify] https://crrev.com/0e96f4580f8f04adc4e5e8a2e3cb33230e67c7f3/ios/chrome/browser/ui/browser_view_controller.mm
,
Jul 31
+kariahda@ for merge approval. Verified on Canary.
,
Jul 31
Approved!
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3117963caa9bd0bf44dcd32005d33c5a9928d6db commit 3117963caa9bd0bf44dcd32005d33c5a9928d6db Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jul 31 15:27:29 2018 Present the InProductHelp when using the TabGrid This CL adds a trigger to the InProductHelp for the LongPress menu when a new Tab is opened from the TabGrid. Bug: 868789 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1fb6b128a4fc59c6f6c349f4cbe01d9c64bf94bf Reviewed-on: https://chromium-review.googlesource.com/1154908 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579058}(cherry picked from commit 0e96f4580f8f04adc4e5e8a2e3cb33230e67c7f3) Reviewed-on: https://chromium-review.googlesource.com/1156824 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#271} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/3117963caa9bd0bf44dcd32005d33c5a9928d6db/ios/chrome/browser/ui/browser_view_controller.mm
,
Aug 7
Verified the issue on 70.0.3515.0 canary tested on iPhone7+(iOS 11.4.1). Tapping on the + in tabgrid opens a new tab and a help pop-up is displayed "Press and hold for more tab options". looks good
,
Aug 8
Issue verified Version: Chrome Beta 69.0.3497.31 Device: iPhone 8 iOS: 11.4 Correct promo displayed https://drive.google.com/open?id=1mHUPoRWI7Xc03JiL-j1n_v3oqJteRhd7 |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Jul 30