New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3%-8.8% regression in webrtc_perf_tests at 23973:23973

Project Member Reported by asapersson@chromium.org, Jul 30

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=868776

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c3685dd8130d075ff1b1d53d24fd84b2250f4948b54fa6842fc5a858f01b3738


Bot(s) for this bug's original alert(s):

webrtc-win-large-tests
Owner: srte@chromium.org
Cc: srte@chromium.org
 Issue 868775  has been merged into this issue.

Comment 4 Deleted

Cc: philipel@chromium.org
Components: Internals>WebRTC
Status: Started (was: Untriaged)
Seems timing related. The CL in question did change the times when probes are sent slightly. The effect is visible on the Linux bots as well, but since the send bandwidth is more noisy there no alert was triggered.

Since the estimated bitrate in this case still is much larger than the required it doesn't affect media quality. However, to ensure a smooth transition I'm working on a CL that makes the probing behavior more similar to the previous behavior.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/da2ec405906b0c42240d80ffe9df1470d7883fa5

commit da2ec405906b0c42240d80ffe9df1470d7883fa5
Author: Sebastian Jansson <srte@webrtc.org>
Date: Thu Aug 02 15:36:12 2018

Always sends probes when they are generated.

This changes makes the usage of the new probe controller reflect how the
old probe controller was used. That is probes are now sent as soon as
they are generated. This is to avoid regressions in performance doe to
the timing of the sent probes.

Bug:  chromium:868776 
Change-Id: I722585689258c9b01e8f1dc47249b284a05a2793
Reviewed-on: https://webrtc-review.googlesource.com/91441
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24175}
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/BUILD.gn
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/goog_cc_network_control.cc
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/goog_cc_network_control.h
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/probe_controller.cc
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/probe_controller.h
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/goog_cc/probe_controller_unittest.cc
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/include/send_side_congestion_controller.h
[modify] https://crrev.com/da2ec405906b0c42240d80ffe9df1470d7883fa5/modules/congestion_controller/send_side_congestion_controller.cc

Status: Fixed (was: Started)
Recovered after landing a fix in WebRTC.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08a84a069d2f5f440e5b84e8903dd5515647dd7

commit e08a84a069d2f5f440e5b84e8903dd5515647dd7
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 03 18:09:11 2018

Roll src/third_party/webrtc f5cf02ac2c4a..d54f5f5c763c (16 commits)

https://webrtc.googlesource.com/src.git/+log/f5cf02ac2c4a..d54f5f5c763c


git log f5cf02ac2c4a..d54f5f5c763c --date=short --no-merges --format='%ad %ae %s'
2018-08-03 sakal@webrtc.org Rename rtc_instrumentation_test_apk targets to end with _test_apk.
2018-08-03 magjed@webrtc.org Android: Remove custom matrix helper functions in RendererCommon
2018-08-03 mbonadei@webrtc.org Remove definition of FEATURE_ENABLE_VOICEMAIL, FEATURE_ENABLE_PSTN.
2018-08-03 philipel@webrtc.org Reland "Remove RTPVideoHeader::h264() accessors."
2018-08-03 oprypin@webrtc.org JNI generation: Replace base::subtle::AtomicWord with std::atomic<>
2018-08-03 buildbot@webrtc.org Roll chromium_revision 4dd959af57..06e87fb3dc (579686:580149)
2018-08-03 oprypin@webrtc.org Don't allocate an array of size 0, it causes a UBSan failure
2018-08-03 kthelgason@webrtc.org Remove dead code.
2018-08-02 zstein@webrtc.org Add AsyncResolverFactory interface and basic implementation.
2018-08-02 srte@webrtc.org Always sends probes when they are generated.
2018-08-02 nisse@webrtc.org Delete class TelephoneEventHandler and related code.
2018-08-02 kthelgason@webrtc.org Fix occasional crash in iOS ADM.
2018-08-02 nisse@webrtc.org Delete telephone-event handling from RTPReceiverAudio.
2018-08-02 oprypin@webrtc.org Fix a warning about comparison of integers of different signs
2018-08-02 philipel@webrtc.org Add members for the codec agnostic descriptor to RTPVideoHeader.
2018-08-02 sakal@webrtc.org Delete MockRenderer and replace it with identical MockSink class.


Created with:
  gclient setdep -r src/third_party/webrtc@d54f5f5c763c

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:867475,chromium:None,chromium:868776,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If94dce305aee0c40ca6d1f33f6b41d966662affe
Reviewed-on: https://chromium-review.googlesource.com/1162105
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580599}
[modify] https://crrev.com/e08a84a069d2f5f440e5b84e8903dd5515647dd7/DEPS

Cc: nisse@google.com
 Issue 871153  has been merged into this issue.
Labels: M-70

Sign in to add a comment