New issue
Advanced search Search tips

Issue 868770 link

Starred by 2 users
Status: Duplicate
Owner:
estevenson@chromium.org
Closed: Aug 27
Cc:
agrieve@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Switch to R8 for Java code optimization

Project Member Reported by estevenson@chromium.org, Jul 30 
https://r8.googlesource.com/r8/

We've already switched to D8 for dexing and we should try to switch to
R8 for optimization. This will unify our dexing and proguarding rules/scripts and allow us to use the same optimization tool for both upstream and downstream apks.

We'll need to verify that there is no apk size increase v.s. downstream proguard.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99f1915968868430b596db831d90d9b208e93ab

commit c99f1915968868430b596db831d90d9b208e93ab
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Aug 16 14:14:39 2018

[build:android] Use default proguard and multidex for monochrome release

Monochrome is crashing on startup. Fix this by using the default
proguard instead of proguard 6.0.3 for monochrome. In order to stay
under the DEX method limit use multidex for monochrome release builds.

Bug:  874464 ,  868770 
Change-Id: I9f002c26fb6e2b9b1b5d7471dab890090c446a75
Reviewed-on: https://chromium-review.googlesource.com/1176474
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583639}
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/build/config/android/rules.gni
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/chrome/android/BUILD.gn
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/c99f1915968868430b596db831d90d9b208e93ab/third_party/proguard/README.chromium
[delete] https://crrev.com/81bcbe408b0b06d4f534f572a0eaeb4b22f245ca/third_party/proguard/lib/proguard.6.0.3.jar

Comment 2 by estevenson@chromium.org, Aug 27

Mergedinto: 872904
Status: Duplicate (was: Assigned)
►

Sign in to add a comment