Move av1_buildflags from deps to public_deps
Reported by
sabbaku...@yandex-team.ru,
Jul 30
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.42 YaBrowser/18.9.0.1738 (beta) Yowser/2.5 Safari/537.36 Steps to reproduce the problem: - What is the expected behavior? What went wrong? "media/base/video_codecs.h" includes "third_party/libaom/av1_buildflags.h" which is a generated header. This should be a public_deps since it's included in another header file. Did this work before? N/A Chrome version: 68.0.3440.42 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 30.0 r0
,
Jul 30
,
Jul 31
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4003d9cfaca313c3b46cf7900a814c2f2aa6676d commit 4003d9cfaca313c3b46cf7900a814c2f2aa6676d Author: Sergey Abbakumov <sabbakumov@yandex-team.ru> Date: Tue Jul 31 17:38:08 2018 Move av1_buildflags from deps to public_deps "media/base/video_codecs.h" includes "third_party/libaom/av1_buildflags.h" which is a generated header. This should be a public_deps since it's included in another header file. Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8 Bug: 868764 Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8 Reviewed-on: https://chromium-review.googlesource.com/1154528 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579462} [modify] https://crrev.com/4003d9cfaca313c3b46cf7900a814c2f2aa6676d/media/base/BUILD.gn
,
Aug 1
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dtapu...@chromium.org
, Jul 30