New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868755 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860366



Sign in to add a comment

Replace page_cycler_v2.typical_25 with loading.desktop on Chrome OS

Project Member Reported by vovoy@chromium.org, Jul 30

Issue description

page_cycler_v2.typical_25 is deprecated. Measuring page loading time with loading.desktop instead.
 
Cc: sullivan@chromium.org tdres...@chromium.org
Cc: vovoy@chromium.org
 Issue 866361  has been merged into this issue.
Running typical loading pages should be sufficient.

./run_benchmark --browser=cros-chrome --remote=DUT_IP --story-tag-filter=typical loading.desktop

CrOS telemetry_Benchmark needs to support adding option --story-tag-filter.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fe7f4a2f99f4729ef824a89ea46a181ad47658ec

commit fe7f4a2f99f4729ef824a89ea46a181ad47658ec
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Tue Aug 07 05:11:26 2018

telemetry_Benchmarks: support adding extra arguments

Some tests require extra arguments to filter the tests and to reduce
test time.

BUG=chromium:868755
TEST=running generate_controlfiles.py and check the control files

Change-Id: If26dd26c74f55389e13c727cf05b97839988da21
Reviewed-on: https://chromium-review.googlesource.com/1163548
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/fe7f4a2f99f4729ef824a89ea46a181ad47658ec/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py
[modify] https://crrev.com/fe7f4a2f99f4729ef824a89ea46a181ad47658ec/server/site_tests/telemetry_Benchmarks/telemetry_Benchmarks.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d271d7a79564b2756399d29f05268c78a8e1d958

commit d271d7a79564b2756399d29f05268c78a8e1d958
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Wed Aug 08 01:09:05 2018

Add telemetry_Benchmarks.loading.desktop

BUG=chromium:868755
TEST=running telemetry_Benchmarks.loading.desktop

Change-Id: I00df0e0f80984fc5f6e34ffb48e96e386ad6b3fd
Reviewed-on: https://chromium-review.googlesource.com/1164739
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/d271d7a79564b2756399d29f05268c78a8e1d958/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py
[add] https://crrev.com/d271d7a79564b2756399d29f05268c78a8e1d958/server/site_tests/telemetry_Benchmarks/control.loading.desktop

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3d51d9eaada39a22274ba94270f888d8d3dcf050

commit 3d51d9eaada39a22274ba94270f888d8d3dcf050
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Thu Oct 25 14:54:16 2018

autotest: update telemetry_Benchmarks on perf dashboard

BUG=chromium:868755
TEST=none

Change-Id: I41100d12f0df41c73504fb95843db64291b39131
Reviewed-on: https://chromium-review.googlesource.com/1297879
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/3d51d9eaada39a22274ba94270f888d8d3dcf050/tko/perf_upload/perf_dashboard_config.json

Cc: cmt...@chromium.org
how is the progress on this? 
we are having plenty of trouble with page_cyclers... 
so, cmtice is trying to use loading.desktop instead. 
Any reasons why you have not done the replacement?

loading.desktop is ready on Chrome OS. This cr is not closed because loading.desktop is flaky on Chrome OS [1] and page_cycler_v2.typical_25 is not yet removed.

[1] loading.desktop test health: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=telemetry_Benchmarks.loading.desktop

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 10 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment