Issue metadata
Sign in to add a comment
|
A zero-to-nonzero to 19.7% regression in browser_tests at 578747:578897 |
||||||||||||||||||||
Issue descriptionTons of latency changes, couldn't see an obvious cause.
,
Jul 30
578747 - 578863 is the most likely interval for regression although there is 3 different ones reported. Unfortunately there are 117 CLs in that range, not easy to point out the culprit. This is Win7 only regression. I checked if there was any change in infra on this bot, but nothing came up. Looking at the individual breakdown below, it looks like "Render Algorithm Latency" went down but everything else went up: https://chromeperf.appspot.com/report?sid=fb64fa9d58947b6141af4648c671febce9d5b24042c4204c38fd677f9f1094aa&start_rev=577187&end_rev=578955 "Render Algorithm Latency" corresponds to the time between "WebMediaPlayerMSCompositor::EnqueueFrame" and "WebMediaPlayerMSCompositor::SetCurrentFrame" calls that is actually spent in VideoRendererAlgorithm. This is decided by presentation deadline given in https://cs.chromium.org/chromium/src/cc/layers/video_frame_provider.h?type=cs&sq=package:chromium&g=0&l=62. Render algorithm isn't the culprit here because we have another test where render algorithm is disabled all together(representing playout-delay=0 use case). There, we see that "Compositor Picking Frame Latency" went up, which corresponds to the time between "WebMediaPlayerMSCompositor::SetCurrentFrame" and "WebMediaPlayerMSCompositor::GetCurrentFrame" calls. Since "WebMediaPlayerMSCompositor::GetCurrentFrame" is driven by the vsync interval and presentation update as well, that points to a change in the decided interval. https://chromeperf.appspot.com/report?sid=7c0a38cb7bd46f88cf5dcc4ac385ad2d40d761bfb101ed742432715e9f9d02c4 From the list this one seems to be most likely suspect affecting vsync interval. uwyiming@ or fsamuel@ can you PTAL if this would be related: https://chromium.googlesource.com/chromium/src/+/f0d7951f253c73c2678c83af541481bb34276a40
,
Jul 30
Reverted responsible change in https://chromium-review.googlesource.com/c/chromium/src/+/1153594. If the fix is effective, we should resolve this bug as a dupe of bug 866981 .
,
Jul 30
The suspected range includes https://chromium-review.googlesource.com/c/chromium/src/+/1153594. Do you mean you are going to reverse that CL?
,
Sep 4
Friendly ping. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 29