Triage: This is the same spacing we already use in the tabs. We should be consistent in both areas.

robliao@chromium.org No, no, no! This is NOT consistent with the tabs, because the tabs have additional padding around the label and the icon that balances the spacing between the two. A basic rule of UI design is that you cannot just look at once size in isolation, it needs to be considered relative to others.

Look at the attached image. The new tabs have clearly been specified by an actual UI designer who is familiar with the Material design specs and understands relative spacing. In contrast, the bookmark buttons appear to be the work of programmers screwing around with a bunch of spacing variables without any consistency or understanding.

The bookmarks bar is one of the most use pieces of UI in the world. Is Google seriously unable or unwilling to assign a UI designer to this? If it goes into the stable channel like this you *are* going to get a lot of pushback, and I would guess you are going to get asked why the hell you didn't bother to apply a modicum of design process to one of your flagship pieces of software. Why not save everyone the trouble and fix this now?

Deleted: chrome-bookmarks-ui-disaster.png 31.7 KB

	chrome-bookmarks-ui-disaster.png 31.7 KB View Download

FWIW I don't find a single bookmark entry as egregious as #3 does, but I think that reusing this spacing is still problematic.

Bookmarks-bar items have no visible dividers unless you hover an item. Tabs have a close-x and vertical bar "|" dividers which makes it very clear which item the favicon belong to.

Bookmarks here have nothing separating them apart from their spacing (which we can't increase without a significant drop in density, per  issue 848631 ). Our default favicon doesn't span the full horizontal width so the icon can definitely look like it's almost centered between two items.

Attaching a screenshot highlighting the difference in visual separators as well as 8->6dp and 8->4dp reductions. I think 4dp is too aggressive (see the spacing for Autofill Smoke Test which fills the square favicon). Reopening it for reconsideration.

Deleted: dividers-between-items.png 13.5 KB

	dividers-between-items.png 13.5 KB View Download

Deleted: bookmarks-label-6dp.png 14.5 KB

	bookmarks-label-6dp.png 14.5 KB View Download

Deleted: bookmarks-label-4dp.png 14.7 KB

	bookmarks-label-4dp.png 14.7 KB View Download

Assigning to bettes@. #3 suggests that the original basis for the WontFix may not be correct.

It's pretty sad that now we have to BEG to get the NORMAL bookmark manager back, when it was a perfectly working piece of code.  Moreover why take away the OPTION for those who wish to re-enable it by this flag? 

chrome://flags/#enable-md-bookmarks

Shaking my head...

This bug only relates to the look of items in the bookmarks bar and isn't related to the bookmark manager.

chrome://flags should all be seen as temporary (unlike chrome://settings). Flags are generally untested and may be unsecure and unstable. As such they are neither recommended nor supported. Maintaining flags and options that are not supported carries a cost, so once a feature is fully rolled and not intended to be rolled back these are generally cleaned up.

While entries under chrome://flags will never be supported options, feel free to file feature requests and bugs against the existing bookmark manager (but be more specific): crbug.com/new

Agreed, UI needs to considered relative to the elements around it and we're doing just that. 

6px on the left edge of the bookmark item, combined with a 4px spacing between items ( issue 848631 ), achieves a 16px total between a label and its following favicon. 16px, as you know, is compliant with Material Design specifications. 4px is a common high density unit used throughout desktop formats, and is also the same measurement we use between toolbar items and tabs. 

Thanks for the feedback and consideration. 
 

Deleted: bkmk.png 32.6 KB

	bkmk.png 32.6 KB View Download

 Issue 915473  has been merged into this issue.