New issue
Advanced search Search tips

Issue 868674 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: shader->id_ != PaintShader::kInvalidRecordShaderId in paint_op_writer.cc

Project Member Reported by ClusterFuzz, Jul 28

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5963450770259968

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  shader->id_ != PaintShader::kInvalidRecordShaderId in paint_op_writer.cc
  cc::PaintOpWriter::Write
  cc::PaintOpWriter::Write
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=578890:578891

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5963450770259968

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 28

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 28

Labels: Test-Predator-Auto-Owner
Owner: p...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/66bcb57a90138959ea5a42de0677ceb3cc0a40f0 (Reland "cc, gpu: Make serialization code bitness agnostic.").

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf6bde4c0d99b0d9a2d9f72380ca2157bebfc97

commit 8cf6bde4c0d99b0d9a2d9f72380ca2157bebfc97
Author: Adrienne Walker <enne@chromium.org>
Date: Wed Aug 01 22:03:36 2018

cc: Add more checks to reading PaintShaders

Previously it was possible to have non-record shaders have a record,
which is invalid.  If these get written back out again, they are not
valid and will DCHECK.  We should just prevent these in the first place.

Bug:  868674 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3da083024fcd47c4577b2a59c9a3014da2097e50
Reviewed-on: https://chromium-review.googlesource.com/1159113
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579960}
[modify] https://crrev.com/8cf6bde4c0d99b0d9a2d9f72380ca2157bebfc97/cc/paint/paint_op_reader.cc

Project Member

Comment 4 by ClusterFuzz, Aug 3

ClusterFuzz has detected this issue as fixed in range 579911:580305.

Detailed report: https://clusterfuzz.com/testcase?key=5963450770259968

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  shader->id_ != PaintShader::kInvalidRecordShaderId in paint_op_writer.cc
  cc::PaintOpWriter::Write
  cc::PaintOpWriter::Write
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=578890:578891
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=579911:580305

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5963450770259968

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Aug 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5963450770259968 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment