Issue metadata
Sign in to add a comment
|
Video stops in last Canary builds |
||||||||||||||||||||||
Issue descriptionChrome Version : 70.0.3505.0 URLs (if applicable) : http://joemonster.org/filmy/92251/Jazda_tirem_pod_prad_na_ekspresowce OS version : 8, 8.1 Special chrome flags (if applicable): none Behavior in older Chrome (if known): OK Video issue, Audio issue, both, neither? video What steps will reproduce the problem? (1)open page and start playing video What is the expected result? video is playing What is the actual result? sound is playing, video stops after about 2 or 3 seconds Any additional information (anything else which may help us debug the issue)? Stable OK, Beta OK, it seems to be added to Canary in last week (or let's say last 10 days) happens on various pages visible on S7 with Android 8 and Pixel with P beta
,
Jul 29
Hmm inconsistent repro actually even on the link in #0.
,
Jul 29
How frequently so you see this issue?
,
Jul 29
Can't reproduce again, so dropping to RBB pending further reports.
,
Jul 29
Just saw it again, may be config change related: video decoder config changed midstream, new config: codec: h264 format: 1 profile: h264 main coded size: [1280,720] visible rect: [0,0,1280,720] natural size: [1280,720] has extra data? false encryption scheme: Unencrypted rotation: 0°
,
Jul 29
100% reproducible, visible on other sites (for example now I observe it on wykop.pl), related to last Chrome changes, not device or OS version.
,
Jul 29
Thanks. Definitely looks like my change and seems midstream config change related. Will double check that path on Monday.
,
Jul 30
Nothing interesting on trace or in adb logcat on my Pixel2 XL. Trying to repro on my 5x w/ debug oreo.
,
Jul 30
Fix here https://chromium-review.googlesource.com/c/chromium/src/+/1155640 but don't love the initial solution. Please advise liberato!
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e commit 2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon Jul 30 23:01:32 2018 Ensure the codec loop is pumped after EOS while waiting for outputs. With the async API, MediaCodec will stop sending callbacks once an EOS buffer has been enqueued. Our MediaCodec based decoders give up their timer for the async API, so without these notifications we can end up in a hung state. This modifies CodecWrapper::output_buffer_release_cb to include the draining||drained state and then has MediaCodecVideoDecoder make an informed decision to elide the PumpCodec() if possible. BUG= 868670 TEST=https://shaka-player-demo.appspot.com/demo/#asset=https://demo.unified-streaming.com/video/tears-of-steel/tears-of-steel.ism/.mpd;lang=en-US;build=compiled will hang for multiple seconds without patch between adaptations. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I442b3ecdeaa5e87c28002f3cf45a905d31fd6d2e Reviewed-on: https://chromium-review.googlesource.com/1155640 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579218} [modify] https://crrev.com/2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e/media/gpu/android/codec_wrapper.cc [modify] https://crrev.com/2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e/media/gpu/android/codec_wrapper.h [modify] https://crrev.com/2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e/media/gpu/android/codec_wrapper_unittest.cc [modify] https://crrev.com/2aeda9bc8fb1672bc2819cb18e219dd24d7fea6e/media/gpu/android/media_codec_video_decoder.cc
,
Jul 30
,
Jul 30
Tagging friday to double check metrics.
,
Jul 31
Fix should be in 70.0.3508.0, let me know if you still have issues marcin@
,
Aug 3
The NextAction date has arrived: 2018-08-03
,
Aug 3
Doesn't repro for me on canary anymore. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dalecur...@chromium.org
, Jul 29Labels: ReleaseBlock-Dev M-70
Owner: dalecur...@chromium.org
Status: Assigned (was: Unconfirmed)