New issue
Advanced search Search tips

Issue 868657 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: args->GetNext(&key) in test_runner.cc

Project Member Reported by ClusterFuzz, Jul 28

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6672837902073856

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args->GetNext(&key) in test_runner.cc
  test_runner::TestRunner::OverridePreference
  gin::internal::Dispatcher<void
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=578618:578619

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6672837902073856

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 28

Components: Blink>Bindings
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 28

Labels: Test-Predator-Auto-Owner
Owner: delph...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/382a596abf7cbc3ef3c77398d25ff5062487e561 ([cleanup] Fix uses of deprecated *Value methods in content_shell).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Jul 29

Labels: OS-Windows
Project Member

Comment 4 by ClusterFuzz, Jul 31

ClusterFuzz has detected this issue as fixed in range 579262:579264.

Detailed report: https://clusterfuzz.com/testcase?key=6672837902073856

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  args->GetNext(&key) in test_runner.cc
  test_runner::TestRunner::OverridePreference
  gin::internal::Dispatcher<void
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=578618:578619
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=579262:579264

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6672837902073856

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jul 31

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6672837902073856 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c16b3c488f056e7cf5015a108e90ac4a04fdca4

commit 4c16b3c488f056e7cf5015a108e90ac4a04fdca4
Author: Dan Elphick <delphick@chromium.org>
Date: Tue Jul 31 12:15:11 2018

Make overridePreference throw on argument parsing failures

Previously it would CHECK, which would be fine since this is
non-production code, but clusterfuzz strenuously objected.

Bug:  868657 
Change-Id: I9744b8e36be7d4645a1901656453608d7068671f
Reviewed-on: https://chromium-review.googlesource.com/1154978
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579379}
[modify] https://crrev.com/4c16b3c488f056e7cf5015a108e90ac4a04fdca4/content/shell/test_runner/test_runner.cc
[add] https://crrev.com/4c16b3c488f056e7cf5015a108e90ac4a04fdca4/third_party/WebKit/LayoutTests/fast/harness/override-preferences-3.html

Sign in to add a comment