📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14d1425ba40000

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14d1425ba40000

Roll src/third_party/catapult a1e31db3c6b7..787a378926fb (1 commits) by catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/14771d4df09bb73a5440b052ea25481bbbdfbe05
0 → 1 (+1)

Assigning to sheriff sullivan@chromium.org because "Roll src/third_party/catapult a1e31db3c6b7..787a378926fb (1 commits)" is a roll.

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

This was reverted.

This is still happening with the reland:

Build failure: https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf/2145

Log: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/c4eb8ae4-9538-11e8-8152-0242ac110007

(ERROR) 2018-08-01 02:03:26,135 page_test_results.Fail:540  Failure recorded: Error: Unexpected duplicate step: IssueBeginFrame
    at eventIsValidGraphicsEvent (/tracing/metrics/rendering_metric.html:221:15)
    at addPipelineHistograms (/tracing/metrics/rendering_metric.html:241:12)
    at new renderingMetric (/tracing/metrics/rendering_metric.html:328:5)
    at runMetrics (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:61:16)
    at metricMapFunction (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:190:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)



sadrul@: can you fix the bug with the rendering_metric.html?

Trace where the error can be see: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/gws_boogie_expansion_2018-08-01_02-02-59_78073.html

Ping sadrul, the rendering benchmark tests are still failing.

I have a fix. Putting up the CL for review.

https://chromium-review.googlesource.com/c/catapult/+/1161113

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d38bbdff043da3482cc0c60d44f97b172a82c1f4

commit d38bbdff043da3482cc0c60d44f97b172a82c1f4
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Aug 03 02:05:33 2018

rendering: Fix filtering events.

It is possible for a segment to be completely contained in another
segment, or overlap other segments. The rendering metric processes
the trace events within these segments multiple times, leading to
unexpected results. This fixes that by updating the logic to filter
out events, so that each event is processed only once.

BUG= chromium:868650 

Change-Id: Ie85afd9861037efd1d24588bedb883c079ab4d54
Reviewed-on: https://chromium-review.googlesource.com/1161113
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/d38bbdff043da3482cc0c60d44f97b172a82c1f4/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/d38bbdff043da3482cc0c60d44f97b172a82c1f4/tracing/tracing/metrics/rendering_metric.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dd04b830740c58d03a67a1fbd5c8f72efa5cbf4

commit 6dd04b830740c58d03a67a1fbd5c8f72efa5cbf4
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 03 07:56:46 2018

Roll src/third_party/catapult e16a2e80be66..d38bbdff043d (1 commits)

https://chromium.googlesource.com/catapult.git/+log/e16a2e80be66..d38bbdff043d


git log e16a2e80be66..d38bbdff043d --date=short --no-merges --format='%ad %ae %s'
2018-08-03 sadrul@chromium.org rendering: Fix filtering events.


Created with:
  gclient setdep -r src/third_party/catapult@d38bbdff043d

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:868650 
TBR=sullivan@chromium.org

Change-Id: I7264905b5a4821446dcdf3f49b95132105460608
Reviewed-on: https://chromium-review.googlesource.com/1161147
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580472}
[modify] https://crrev.com/6dd04b830740c58d03a67a1fbd5c8f72efa5cbf4/DEPS

This is fixed: https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf/2166

Thanks Sadrul!