New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

rendering.desktop/microsoft_video_city in performance_test_suite failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 28

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@google.com

rendering.desktop/microsoft_video_city  in performance_test_suite failing on multiple builders

Builders failed on: 
- linux-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/linux-perf
- mac-10_12_laptop_low_end-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/mac-10_12_laptop_low_end-perf

They all have the same failure log:

Unexpected duplicate step: ReceiveCompositorFrame
    at eventIsValidGraphicsEvent (/tracing/metrics/rendering_metric.html:220:15)
    at addPipelineHistograms (/tracing/metrics/rendering_metric.html:240:12)
    at RegisteredTypeInfo.renderingMetric [as constructor] (/tracing/metrics/rendering_metric.html:327:5)
    at runMetrics (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:61:16)
    at metricMapFunction (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:190:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)



 
Labels: -Pri-2 Pri-1
Cc: catapult...@skia-buildbots.google.com.iam.gserviceaccount.com
Owner: sullivan@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15fe028da40000

Roll src/third_party/catapult a1e31db3c6b7..787a378926fb (1 commits) by catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/14771d4df09bb73a5440b052ea25481bbbdfbe05
0 → 0.9571 (+0.9571)

Assigning to sheriff sullivan@chromium.org because "Roll src/third_party/catapult a1e31db3c6b7..787a378926fb (1 commits)" is a roll.

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad

commit e05f902a692909dd57b3d3ddbf081c9e1ce2dbad
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Jul 28 14:50:51 2018

Revert "rendering: Add pipeline metrics."

This reverts commit 787a378926fb5ce10acf8e27cb2bb715fec07f6e.

Reason for revert: breaking some stories on rendering benchmarks

BUG: chromium:868648 

Original change's description:
> rendering: Add pipeline metrics.
> 
> Report metrics about the duration of various steps in the compositor
> pipeline.
> 
> BUG=chromium:855328
> 
> Change-Id: Iedd7c3bbf3e64154c58454e86b710f5b395c9909
> Reviewed-on: https://chromium-review.googlesource.com/1103792
> Reviewed-by: Ben Hayden <benjhayden@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

TBR=sadrul@chromium.org,benjhayden@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:855328
Change-Id: I94d9218ed951be336757685c5e8bcaf0a97f5ea3
Reviewed-on: https://chromium-review.googlesource.com/1154367
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad/tracing/tracing/metrics/rendering_metric.html

Labels: -Pri-1 Pri-3
Owner: sadrul@chromium.org
Reassigning to Sadrul since it was https://chromium-review.googlesource.com/c/catapult/+/1103792 that broke the metrics, but lowering priority since the CL has been reverted (Thanks, Ned!)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/94294baed844211842477caaa722e58a257e5db3

commit 94294baed844211842477caaa722e58a257e5db3
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jul 31 19:41:41 2018

Reland "rendering: Add pipeline metrics."

Report metrics about the duration of various steps in the compositor
pipeline.

BUG=chromium:855328,  chromium:868648 

Change-Id: I29fb8907bc2d00c8601820c25cb1ffd210d3bac6
Reviewed-on: https://chromium-review.googlesource.com/1156061
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

[modify] https://crrev.com/94294baed844211842477caaa722e58a257e5db3/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/94294baed844211842477caaa722e58a257e5db3/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf136214445b8018d40cc60ea12ad9e80c8cd53

commit 0bf136214445b8018d40cc60ea12ad9e80c8cd53
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 31 23:31:48 2018

Roll src/third_party/catapult 100f0ee2ceb7..44d40fafd233 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/100f0ee2ceb7..44d40fafd233


git log 100f0ee2ceb7..44d40fafd233 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 nednguyen@google.com Improve error message of unhandleable error
2018-07-31 sadrul@chromium.org Reland "rendering: Add pipeline metrics."
2018-07-31 dtu@chromium.org [pinpoint] Don't wrap quest name in status box header.


Created with:
  gclient setdep -r src/third_party/catapult@44d40fafd233

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:869548 ,chromium:855328, chromium:868648 
TBR=sullivan@chromium.org

Change-Id: If13c6ea7fc05a6ae309af1c0de781fc9e558af60
Reviewed-on: https://chromium-review.googlesource.com/1156917
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579619}
[modify] https://crrev.com/0bf136214445b8018d40cc60ea12ad9e80c8cd53/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment