New issue
Advanced search Search tips

Issue 868630 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 856904
issue 874977



Sign in to add a comment

libcxx/libcxxabi: `use` must not be used in global scope

Project Member Reported by vapier@chromium.org, Jul 28

Issue description

this code is invalid in ebuilds:
if use llvm-next; then
    CROS_WORKON_COMMIT="ff6224a58cf9348c10b17c7ea707d5228c5101c5"
    CROS_WORKON_TREE="930f377a3dab90e3413eed81f8a55dff32fce18d"
else
    CROS_WORKON_COMMIT="1e705dad853445419ccc8d35d82de263e91de3f3"
    CROS_WORKON_TREE="334ca76de56b9d026c1b20885a2a98645b12e8f6"
fi

you can never call `use` in global scope.

 * ERROR: cross-x86_64-cros-linux-gnu/libcxxabi-4.0.0-r35::crossdev failed (depend phase):
 *   use() calls are not allowed in global scope
 
Summary: libcxx/libcxxabi: `use` must not be used in global scope (was: libcxx: `use` must not be used in global scope)
looks like libcxxabi has the same exact problem
llvm/libunwind probably are doing it as well.
How to repro this error?
it's on newer versions of portage

you have to delay use calls to src funcs. doesn't seem too hard to migrate.

Comment 4 Deleted

Comment 5 Deleted

Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b

commit cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b
Author: Manoj Gupta <manojgupta@google.com>
Date: Sun Aug 12 03:50:32 2018

Remove uses of "if use llvm-next" from global scope.

Move all of global scope uses to src_unpack functions in toolchain ebuilds.

Also move the "-rN" suffix to a symlink. This makes it easier
to resolve conflicting changes to the ebuilds.

BUG= chromium:868630 
TEST=No change in built files.

Change-Id: Ia71b373ba19e935389d21d6b4ed6534d6810584d
Reviewed-on: https://chromium-review.googlesource.com/1172056
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-libs/libcxx/libcxx-7.0.0-r3.ebuild
[modify] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-libs/libcxxabi/libcxxabi-7.0.0.ebuild
[add] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-devel/llvm/llvm-7.0_pre333878_p20180808-r2.ebuild
[modify] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-libs/libcxx/libcxx-7.0.0.ebuild
[rename] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-libs/libcxxabi/libcxxabi-7.0.0-r3.ebuild
[rename] https://crrev.com/cd0ca750a9f02e367c44cdb93acc8ef7ea1cd15b/sys-devel/llvm/llvm-7.0_pre333878_p20180808.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/af366bcd24811deafe539841500d2875347e8276

commit af366bcd24811deafe539841500d2875347e8276
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Aug 14 00:48:56 2018

Move git hashes to global scope.

BUG= chromium:868630 
TEST=No change in built files.

Change-Id: I86d901d053f3960138e075f3a0bf4788893da5a7
Reviewed-on: https://chromium-review.googlesource.com/1172082
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/libcxx/libcxx-7.0.0-r4.ebuild
[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/libcxxabi/libcxxabi-7.0.0-r4.ebuild
[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/compiler-rt/compiler-rt-7.0_pre333878.ebuild
[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-devel/lld/lld-7.0_pre333878.ebuild
[modify] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/libcxxabi/libcxxabi-7.0.0.ebuild
[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-devel/llvm/llvm-7.0_pre333878_p20180808-r3.ebuild
[add] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/llvm-libunwind/llvm-libunwind-7.0_pre333878-r2.ebuild
[rename] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/llvm-libunwind/llvm-libunwind-7.0_pre333878.ebuild
[add] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-devel/lld/lld-7.0_pre333878-r2.ebuild
[add] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/compiler-rt/compiler-rt-7.0_pre333878-r2.ebuild
[modify] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-libs/libcxx/libcxx-7.0.0.ebuild
[modify] https://crrev.com/af366bcd24811deafe539841500d2875347e8276/sys-devel/llvm/llvm-7.0_pre333878_p20180808.ebuild

Status: Fixed (was: Assigned)
Blocking: 874977

Sign in to add a comment