Seems a lot of places don't respect the display workarea. this will also affect the chromevox panel.

There is even a bigger bug here (see linked video below). If the window is positioned in such a way that its center lies in another display, the newly created display will not show at all.

I'll fix both bugs here.


https://drive.google.com/file/d/18VmlvG5yV9ceFIms9t-d9bXRQLmF9Duk/view?usp=sharing

Should look like this when fixed.

Deleted: Screenshot from 2018-10-04 17-42-43.png 72.7 KB

	Screenshot from 2018-10-04 17-42-43.png 72.7 KB View Download

Aside: Many a11y features only work on the primary display -- they have hard-coded calls to ash::Shell::GetPrimaryRootWindow(). I think ChromeVox does this. It has never been clear to me which features are expected to work on multi-monitor.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8777914c856ff442638cd02c98d05513df3655

commit 2f8777914c856ff442638cd02c98d05513df3655
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Wed Oct 10 19:34:49 2018

Fix extension dialog positioning when docked magnifier enabled

This CL fixes two issues:
- The extension dialog sizing should take into account
  the reduced display's workarea when either the docked
  magnifier, or chromevox are enabled.
- It should also use the correct display, which is the
  display when the parent window resides in the window
  tree, not the display where the center of the parent
  widnow resides, as they may be different.

BUG= 868625 
TEST=Added new browser tests

Change-Id: I6a12a071075663e151397860e60c45e2c39025c6
Reviewed-on: https://chromium-review.googlesource.com/c/1262646
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598452}
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/collected_cookies_browsertest.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/test/test_browser_dialog.h
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/views/accessibility/invert_bubble_view_browsertest.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/views/extensions/extension_dialog.cc
[add] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/views/extensions/extension_dialog_bounds_browsertest.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/2f8777914c856ff442638cd02c98d05513df3655/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f056138fe3e21a608be9735eafe3d2fa69e5423f

commit f056138fe3e21a608be9735eafe3d2fa69e5423f
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Thu Oct 11 02:44:50 2018

Fix flakiness on Win7 when testing dialog bounds.

Exclude AuthenticatorDialogTest from dialog bounds
testing since it may position itself outside the
display's work area bounds.

TBR=msw@chromium.org,thomasanderson@chromium.org
BUG= 868625 

Change-Id: I67401b4c5793f02c20c1cf96a81a07ccc6f41861
Reviewed-on: https://chromium-review.googlesource.com/c/1275308
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598643}
[modify] https://crrev.com/f056138fe3e21a608be9735eafe3d2fa69e5423f/chrome/browser/ui/webauthn/authenticator_dialog_browsertest.cc