New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868610 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 868055



Sign in to add a comment

Allow test_runner.py to run junit4 tests using ndroid.support.test.runner.AndroidJUnitRunner

Project Member Reported by aluo@chromium.org, Jul 28

Issue description

Version is 0.5 under third_party/android_support_test_runner but the current version is 1.0.2 which supports running junit4 tests.  This is needed to run the android.autofillservice.cts.WebViewActivityTest CTS tests that webview needs.
 
Blocking: 868055
Owner: aluo@chromium.org
Status: Assigned (was: Untriaged)
Looks like the issue is the test_runner.py script throwing errors when junit 4 tests are encountered using the android test runner.
uh, that sounds like something odd in the CTS tests -- test_runner.py runs many junt4 tests.

What specifically is the error?
Cc: felipeal@google.com
Yea the original diagnosis is wrong, the issue is MissingJUnit4RunnerException being thrown due to the test_runner not recognizing android.support.test.runner.AndroidJUnitRunner as a junit4 runner.  Cl is here: https://chromium-review.googlesource.com/c/chromium/src/+/1155969
Summary: Allow test_runner.py to run junit4 tests using ndroid.support.test.runner.AndroidJUnitRunner (was: Update android support test runner to latest version)
Updated Summary from "Update android support test runner to latest version" to "Allow test_runner.py to run junit4 tests using ndroid.support.test.runner.AndroidJUnitRunner".  Also please ignore the description, although it would be nice to update that too at some point.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454331530fc758e9cc9d5d023110429419f5ddc7

commit 454331530fc758e9cc9d5d023110429419f5ddc7
Author: Andrew Luo <aluo@chromium.org>
Date: Thu Aug 16 19:53:05 2018

Allow android.support.test.runner.AndroidJUnitRunner to run junit4 tests in test_runner.py

Bug:  868610 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8ae54ae93effd83a9197d22d36df9536a5dfa631
Reviewed-on: https://chromium-review.googlesource.com/1155969
Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583779}
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/android_webview/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/android_webview/tools/automated_ui_tests/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/android_webview/tools/system_webview_shell/page_cycler/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/chrome/android/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/chrome/android/sync_shell/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/components/cronet/android/sample/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/components/cronet/android/test/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/components/test/android/browsertests_apk/AndroidManifest.xml.jinja2
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/content/shell/android/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/mojo/public/java/system/javatests/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/net/android/unittest_support/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/remoting/android/javatests/AndroidManifest.xml.jinja2
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/testing/android/driver/java/AndroidManifest.xml
[modify] https://crrev.com/454331530fc758e9cc9d5d023110429419f5ddc7/testing/android/native_test/java/AndroidManifest.xml.jinja2

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4861434976fb0a75fa5e195c87406f2e4490c41e

commit 4861434976fb0a75fa5e195c87406f2e4490c41e
Author: Andrew Luo <aluo@google.com>
Date: Sat Aug 18 01:17:50 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/902093493b608a1172248b85510bea291419c6ca

commit 902093493b608a1172248b85510bea291419c6ca
Author: Andrew Luo <aluo@chromium.org>
Date: Mon Aug 20 19:22:29 2018

Default runner to junit4

Bug:  chromium:868610 
Change-Id: Ifc457d8e74cf42e9ba4d21807721f86c521b35e9
Reviewed-on: https://webrtc-review.googlesource.com/94440
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#24350}
[modify] https://crrev.com/902093493b608a1172248b85510bea291419c6ca/examples/androidtests/AndroidManifest.xml
[modify] https://crrev.com/902093493b608a1172248b85510bea291419c6ca/sdk/android/instrumentationtests/AndroidManifest.xml
[modify] https://crrev.com/902093493b608a1172248b85510bea291419c6ca/test/android/AndroidManifest.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b2faa198a3a2ab3a713bbb1b2d5d6ebd90f288

commit 76b2faa198a3a2ab3a713bbb1b2d5d6ebd90f288
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 21 03:33:00 2018

Roll src/third_party/webrtc 820ebd0f6616..bcdf5f1a944e (2 commits)

https://webrtc.googlesource.com/src.git/+log/820ebd0f6616..bcdf5f1a944e


git log 820ebd0f6616..bcdf5f1a944e --date=short --no-merges --format='%ad %ae %s'
2018-08-20 buildbot@webrtc.org Roll chromium_revision c092e144b5..e247d79575 (584376:584490)
2018-08-20 aluo@chromium.org Default runner to junit4


Created with:
  gclient setdep -r src/third_party/webrtc@bcdf5f1a944e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:868610
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5fb236891fecb882f247195ee49737cfe1bfa7eb
Reviewed-on: https://chromium-review.googlesource.com/1182203
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584634}
[modify] https://crrev.com/76b2faa198a3a2ab3a713bbb1b2d5d6ebd90f288/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8d5bc578e5107d2b0b3b9ea9f7e0642dc434e9f6

commit 8d5bc578e5107d2b0b3b9ea9f7e0642dc434e9f6
Author: Oleh Prypin <oprypin@google.com>
Date: Tue Aug 21 10:12:45 2018

Revert "Default runner to junit4"

This reverts commit 902093493b608a1172248b85510bea291419c6ca.

Reason for revert: Breaks downstream project

Original change's description:
> Default runner to junit4
>
> Bug:  chromium:868610 
> Change-Id: Ifc457d8e74cf42e9ba4d21807721f86c521b35e9
> Reviewed-on: https://webrtc-review.googlesource.com/94440
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Andrew Luo <aluo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#24350}

TBR=phoglund@webrtc.org,sakal@webrtc.org,jbudorick@chromium.org,aluo@chromium.org

Change-Id: Ie972a2500bc15ff95d8c61a0ace681387b657ae7
No-Try: true
Bug:  chromium:868610 
Reviewed-on: https://webrtc-review.googlesource.com/95060
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@google.com>
Cr-Commit-Position: refs/heads/master@{#24354}
[modify] https://crrev.com/8d5bc578e5107d2b0b3b9ea9f7e0642dc434e9f6/examples/androidtests/AndroidManifest.xml
[modify] https://crrev.com/8d5bc578e5107d2b0b3b9ea9f7e0642dc434e9f6/sdk/android/instrumentationtests/AndroidManifest.xml
[modify] https://crrev.com/8d5bc578e5107d2b0b3b9ea9f7e0642dc434e9f6/test/android/AndroidManifest.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d38c1ba836892901911fbcbc6e2d11a8be3ddb3

commit 6d38c1ba836892901911fbcbc6e2d11a8be3ddb3
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 21 16:59:29 2018

Roll src/third_party/webrtc bcdf5f1a944e..c3da6716d42d (9 commits)

https://webrtc.googlesource.com/src.git/+log/bcdf5f1a944e..c3da6716d42d


git log bcdf5f1a944e..c3da6716d42d --date=short --no-merges --format='%ad %ae %s'
2018-08-21 peah@webrtc.org AEC3: Adding another config parameter and matching json reader with config
2018-08-21 ilnik@webrtc.org Move FakeCodec to separate target and behave like real encoder.
2018-08-21 mbonadei@webrtc.org Add documentation for WEBRTC_EXCLUDE_BUILT_IN_SSL_ROOT_CERTS.
2018-08-21 srte@webrtc.org Removes unused reserved bitrate in BitrateController.
2018-08-21 sprang@webrtc.org Simulcast screenshare adjustment to temporal layers, bitrate
2018-08-21 ssilkin@webrtc.org Allow VP9 flexible mode.
2018-08-21 oprypin@google.com Revert "Default runner to junit4"
2018-08-21 nisse@webrtc.org Delete unneeded forward declares of RtpReceiver
2018-08-21 nisse@webrtc.org Add accessor methods for RTP timestamp of EncodedImage.


Created with:
  gclient setdep -r src/third_party/webrtc@c3da6716d42d

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:868610
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I51baac50b1606da6758274aa36eb085ed595d85e
Reviewed-on: https://chromium-review.googlesource.com/1183537
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584793}
[modify] https://crrev.com/6d38c1ba836892901911fbcbc6e2d11a8be3ddb3/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/18a86bfcc1aff2f1df54ccac9363b29dcff238bd

commit 18a86bfcc1aff2f1df54ccac9363b29dcff238bd
Author: Andrew Luo <aluo@chromium.org>
Date: Tue Aug 21 17:10:05 2018

Reland "Default runner to junit4"

This is a reland of 902093493b608a1172248b85510bea291419c6ca
(the breakage was unrelated)

Original change's description:
> Default runner to junit4
>
> Bug:  chromium:868610 
> Change-Id: Ifc457d8e74cf42e9ba4d21807721f86c521b35e9
> Reviewed-on: https://webrtc-review.googlesource.com/94440
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Andrew Luo <aluo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#24350}

TBR: phoglund@webrtc.org, sakal@webrtc.org
Cq-Include-Trybots: master.internal.tryserver.corp.webrtc:linux_internal
Bug:  chromium:868610 
Change-Id: Ie67829ccca8b652b0231952159ddbc1dae6b2cde
Reviewed-on: https://webrtc-review.googlesource.com/95200
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24367}
[modify] https://crrev.com/18a86bfcc1aff2f1df54ccac9363b29dcff238bd/examples/androidtests/AndroidManifest.xml
[modify] https://crrev.com/18a86bfcc1aff2f1df54ccac9363b29dcff238bd/sdk/android/instrumentationtests/AndroidManifest.xml
[modify] https://crrev.com/18a86bfcc1aff2f1df54ccac9363b29dcff238bd/test/android/AndroidManifest.xml

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/693dac06d47993ff70019645b6e7b63be97dcea1

commit 693dac06d47993ff70019645b6e7b63be97dcea1
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 22 16:33:15 2018

Roll src/third_party/webrtc 4d95f1eb9beb..efbcb31cb67e (11 commits)

https://webrtc.googlesource.com/src.git/+log/4d95f1eb9beb..efbcb31cb67e


git log 4d95f1eb9beb..efbcb31cb67e --date=short --no-merges --format='%ad %ae %s'
2018-08-22 qingsi@webrtc.org Revert "Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS."
2018-08-22 buildbot@webrtc.org Roll chromium_revision 3e0dea7b74..ab3ab1ba02 (584728:584945)
2018-08-22 qingsi@google.com Revert "Use also the related address in redundancy detection for candidates from"
2018-08-22 qingsi@webrtc.org Revert "Update packetsLost and jitter stats any time a packet is received."
2018-08-21 koloskova@webrtc.org Adds utility function for PCC.
2018-08-21 koloskova@webrtc.org Adds monitor interval class for PCC.
2018-08-21 aluo@chromium.org Reland "Default runner to junit4"
2018-08-21 andersc@webrtc.org Add missing ifdefs to header files for SW video codecs.
2018-08-21 ilnik@webrtc.org Revert "Move FakeCodec to separate target and behave like real encoder."
2018-08-21 koloskova@webrtc.org Adds Rtt tracker for PCC.
2018-08-21 devicentepena@webrtc.org AEC3: adding a config option for applying a more conservative initial phase.


Created with:
  gclient setdep -r src/third_party/webrtc@efbcb31cb67e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:868610,chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7fa8327a149cb62e4f71ab5e23bd64d8b6192d6b
Reviewed-on: https://chromium-review.googlesource.com/1184764
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585056}
[modify] https://crrev.com/693dac06d47993ff70019645b6e7b63be97dcea1/DEPS

Status: Fixed (was: Assigned)
test runner script has been updated manifest files have been updated.

Sign in to add a comment