New issue
Advanced search Search tips

Issue 868602 link

Starred by 1 user
Status: Assigned
Owner:
calamity@chromium.org
Cc:
calamity@chromium.org
khorimoto@chromium.org
dpa...@chromium.org
michae...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Mojo-based BrowserTests fail when chrome.send() is disallowed

Project Member Reported by khorimoto@chromium.org, Jul 27 
This CL removed chrome.send() from Mojo-based WebUI pages:
https://chromium-review.googlesource.com/c/chromium/src/+/1025673

When chrome.send() is disabled, this check gets skipped:
https://cs.chromium.org/chromium/src/chrome/test/data/webui/test_api.js?l=808

This causes tests to finish but hang forever. Example output:
https://paste.googleplex.com/6640000066125824

Comment 1 by dpa...@chromium.org, Jul 27

Summary: Mojo-based BrowserTests fail when chrome.send() is disallowed (was: Mocha-based BrowserTests fail when chrome.send() is disallowed)
Fixing title.

Comment 3 by michae...@chromium.org, Jul 27 

(the issue seems fixed by moving the test into the "browser_tests_js_mojo_webui" target, due to the different test_type parameter for js2gtest -- is that the correct fix?)

Comment 4 by dpa...@chromium.org, Jul 27 

> should probably be updated while we're here.

Any WebUI docs under dev.chromium.org/developers are likely to be fairly obsolete. Newer docs exist under https://chromium.googlesource.com/chromium/src/+/master/docs/, for example see https://chromium.googlesource.com/chromium/src/+/master/docs/webui_explainer.md (although that one does not cover testing).
►

Sign in to add a comment