Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 8686 RTL: Can't select RTL text from Chrome UI boxes
Starred by 4 users Reported by xlyuan@chromium.org, Mar 11 2009 Back to list
Status: Verified
Owner: xji@chromium.org
Closed: Apr 2009
Cc: anan...@chromium.org, jeremy@chromium.org, hbono@chromium.org, xji@chromium.org, js...@chromium.org, idana@chromium.org
Components:
OS: All
Pri: 2
Type: Bug
RTL

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
This is not a regression, happens on all channels builds and Trunk.

Build: 2.0.170.0 (Developer Build 11440)
   OS: Any

Other Browsers:
     Safari4: N/A
Firefox3.0.7: OK
         IE7: OK

Steps:
1. Run Hebrew Chrome
2. Hit Ctrl + F
3. Paste text חה"כ החדש into "Find in page" bar
4. Put cursor into the middle of the text
5. Drag the cursor to the right direction
6. Observe

Result:
Text in the opposite direction is selected

Expected:
Text in the same direction should be selected

Notes:
1. This issue happens on all the Chrome UI text boxes, such as bookmark 
bubble, bookmark manager

2. Doesn't happen on web page
 
Comment 1 by xlyuan@chromium.org, Mar 11 2009
Labels: RTL
Adding "RTL" label.
Labels: mstone-2.0
Status: Assigned
Comment 3 by jon@chromium.org, Apr 3 2009
Labels: JonMoved Mstone-2.1
Moving from milestone 2 to milestone 2.1.
Comment 4 by prog...@gmail.com, Apr 14 2009
i can't even put the caret in the middle of the text using the mouse if the text is in 
Hebrew
it won't move beyond the first character (which is even worst)
same thing goes for the Bookmark manager

i can reproduce what you described if i move the caret using the keyboard
Comment 5 by xji@chromium.org, Apr 21 2009
Status: Fixed
review URL:
http://codereview.chromium.org/86003

fixed in r14158
Comment 6 by bugdro...@gmail.com, Apr 22 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=14158 

------------------------------------------------------------------------
r14158 | xji@chromium.org | 2009-04-21 16:44:02 -0700 (Tue, 21 Apr 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=14158&r2=14157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/text_field.cc?r1=14158&r2=14157

This CL fixes 
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG= 6125 
BUG= 8686 

Review URL: http://codereview.chromium.org/86003
------------------------------------------------------------------------

Comment 7 by xlyuan@chromium.org, Apr 23 2009
Status: Verified
Verified on 2.0.176.0 (Official Build ), can't change insertion point issue has been 
fixed, filed a separated issue 10931 for the selection issue when the selection 
reaches the boundary of the text.

Comment 8 by prog...@gmail.com, Apr 24 2009
this is a big improvement, thanks for the fix :)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15136 

------------------------------------------------------------------------
r15136 | mal@chromium.org | 2009-05-01 23:47:30 -0700 (Fri, 01 May 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=15136&r2=15135
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/views/controls/text_field.cc?r1=15136&r2=15135

Merge r14158.

This CL fixes 
issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
issue 8686 - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG= 6125 
BUG= 8686 
TBR= xji

Review URL: http://codereview.chromium.org/100296
------------------------------------------------------------------------

Labels: -I18N bulkmove Feature-I18N
This is not a regression, happens on all channels builds and Trunk.

Build: 2.0.170.0 (Developer Build 11440)
   OS: Any

Other Browsers:
     Safari4: N/A
Firefox3.0.7: OK
         IE7: OK

Steps:
1. Run Hebrew Chrome
2. Hit Ctrl + F
3. Paste text חה"כ החדש into "Find in page" bar
4. Put cursor into the middle of the text
5. Drag the cursor to the right direction
6. Observe

Result:
Text in the opposite direction is selected

Expected:
Text in the same direction should be selected

Notes:
1. This issue happens on all the Chrome UI text boxes, such as bookmark 
bubble, bookmark manager

2. Doesn't happen on web page
Project Member Comment 11 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 12 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Feature-I18N Cr-UI-I18N
Project Member Comment 13 by bugdroid1@chromium.org, Mar 20 2013
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment