Unable to maximize Chrome window through DevTools on Mac |
|||||||||||
Issue descriptionChrome Version: 70.0.3504.0 (since r578334) OS: MacOS With the latest Chrome builds, sending DevTools Browser.setWindowBounds command with "windowState":"maximized" option no longer has any effects. This causes errors in ChromeDriver features that depend on this command. This is a regression caused by r578334 (macviews: Flip ViewsBrowserMode default). Here is an example output from ChromeDriver log: [1532731751.928][DEBUG]: DEVTOOLS COMMAND Browser.setWindowBounds (id=2) { "bounds": { "windowState": "maximized" }, "windowId": 1070681984 } [29879:775:0727/154911.928147:ERROR:native_widget_mac.mm(515)] Not implemented reached in virtual void views::NativeWidgetMac::Maximize() [1532731751.929][DEBUG]: DEVTOOLS RESPONSE Browser.setWindowBounds (id=2) { } Comments in native_widget_mac.mm seems to indicate that this is now intentionally unimplemented. Is this correct? This will probably cause some breakage for developers who use Chrome through automation tools. If it is really no longer possible to support maximized window on Mac, at least DevTools should return an error for such request.
,
Jul 30
,
Jul 31
Do you know where the implementation of that command is? This is almost certainly related to issue 867551.
,
Jul 31
The implementation of maximize window for Mac appears to be at https://cs.chromium.org/chromium/src/ui/views/widget/native_widget_mac.mm?l=515. It simply calls NOTIMPLEMENTED().
,
Jul 31
,
Aug 9
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/931afa1551c5022f44ccfb1af314004300f0563d commit 931afa1551c5022f44ccfb1af314004300f0563d Author: Tatiana Buldina <buldina@chromium.org> Date: Tue Sep 11 18:53:17 2018 [ChromeDriver] exclude tests for maximize window on Mac Bug:868599 Change-Id: I59ddac3c2c1ada97b252d8d86faf051b4d7ba80b Reviewed-on: https://chromium-review.googlesource.com/1219891 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#590422} [modify] https://crrev.com/931afa1551c5022f44ccfb1af314004300f0563d/chrome/test/chromedriver/test/test_expectations
,
Oct 18
Issue chromedriver:2619 has been merged into this issue.
,
Oct 18
Issue chromedriver:2618 has been merged into this issue.
,
Oct 18
@johnchen@chromium.org @robliao@chromium.org Any ETA when this issue will be fixed?
,
Oct 31
,
Nov 1
Issue chromedriver:2636 has been merged into this issue.
,
Nov 1
Issue chromedriver:2620 has been merged into this issue.
,
Nov 1
robliao@chromium.org: A large number of ChromeDriver users are affected by this issue. Could you please give an update on when this can be fixed? Thanks.
,
Nov 1
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44f994473e625115bc9658f4d8ef49e09bcbfc5a commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a Author: John Chen <johnchen@chromium.org> Date: Thu Nov 01 20:51:53 2018 [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604701} [modify] https://crrev.com/44f994473e625115bc9658f4d8ef49e09bcbfc5a/chrome/test/chromedriver/chrome/chrome_impl.cc [modify] https://crrev.com/44f994473e625115bc9658f4d8ef49e09bcbfc5a/chrome/test/chromedriver/test/run_py_tests.py [modify] https://crrev.com/44f994473e625115bc9658f4d8ef49e09bcbfc5a/chrome/test/chromedriver/test/test_expectations
,
Nov 1
Issue chromedriver:2633 has been merged into this issue.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1f9de6f777241c055cf17611ccede599c260b89 commit a1f9de6f777241c055cf17611ccede599c260b89 Author: John Chen <johnchen@chromium.org> Date: Thu Nov 01 23:17:43 2018 [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: 901110 , 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1313336 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#466} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/chrome/chrome_impl.cc [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/test/run_py_tests.py [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/test/test_expectations
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1f9de6f777241c055cf17611ccede599c260b89 Commit: a1f9de6f777241c055cf17611ccede599c260b89 Author: johnchen@chromium.org Commiter: johnchen@chromium.org Date: 2018-11-01 23:17:43 +0000 UTC [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: 901110 , 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1313336 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#466} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 2
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f31af7a896ba86cd845b6c11f32e7af2499455 commit 27f31af7a896ba86cd845b6c11f32e7af2499455 Author: John Chen <johnchen@chromium.org> Date: Mon Nov 05 20:51:40 2018 [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: chromium:901110 , chromium:868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1318448 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1065} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/chrome/chrome_impl.h [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/test/run_py_tests.py
,
Nov 19
***Mass UI Triage*** robliao@ could you please help in verifying the issue?
,
Jan 10
Is there any update on this? I can still see the issue on Chrome 71 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by meh...@chromium.org
, Jul 28