Some analyzers appear to never finish when there are binary files in the change |
||
Issue descriptionExample: https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1101311 What's happening here is: - The analyzers are exiting prematurely and not writing results data. - The collect handler is getting the result (with empty results) and passing it on to the worker done rpc. - Then the worker done RPC is failing immediately, saying that the request is invalid since there's no result data. Proposed changes: - Obviously, fix the current issue with the analyzers - Also, the worker done handler could still go on and mark the worker as done (and probably mark it as failed and log an error).
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/df3038996ab7532cb845bc3b30ea345419ff90dc commit df3038996ab7532cb845bc3b30ea345419ff90dc Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Jul 31 16:47:55 2018 [tricium] Refactor rpc_worker_done.go and test The purpose of this is to clarify this file, and also prepare for fixing crbug.com/868595 (function state never gets updated if there is no output). This CL should not affect behavior, though it does change comments, tests, and logging. Bug: 868595 Change-Id: Ie5dc81b92e84cb59d8930c1a281491290f265c0b Reviewed-on: https://chromium-review.googlesource.com/1155840 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/df3038996ab7532cb845bc3b30ea345419ff90dc/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go [modify] https://crrev.com/df3038996ab7532cb845bc3b30ea345419ff90dc/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go [modify] https://crrev.com/df3038996ab7532cb845bc3b30ea345419ff90dc/go/src/infra/tricium/appengine/tracker/tracker.infra_testing
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ba70c34c3200293bb7fab6b0cedcf2a754ab71e5 commit ba70c34c3200293bb7fab6b0cedcf2a754ab71e5 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Jul 31 20:41:26 2018 [tricium] Track workers that have no output This changes the validation of worker done requests so that requests with no output are accepted. This means that some requests with no output will go on to be processed, and if the worker is an analyzer, we want to just report no comments and set the state to whatever the request says to set the state to (e.g. FAILURE if the return code is non-zero). Bug: 868595 Change-Id: Iec0315e9e15329d03663df578c4f1149613297ef Reviewed-on: https://chromium-review.googlesource.com/1157137 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/ba70c34c3200293bb7fab6b0cedcf2a754ab71e5/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go [modify] https://crrev.com/ba70c34c3200293bb7fab6b0cedcf2a754ab71e5/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go
,
Jul 31
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 29