Issue metadata
Sign in to add a comment
|
ChromeVox skipping search results in launcher |
||||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3505.0 OS: ChromeOS Board: Kevin What steps will reproduce the problem? (1) Open launcher and type something into search box that gives results (e.g. chrome). (2) Open ChromeVox. (3) Press search key + arrow key several times. What is the expected result? Focus shifts down 1 result at a time. What happens instead? Focus shifts down 2 results at a time.
,
Aug 1
,
Aug 1
Marking P-1 for M-70 as this badly regressed the chromevox experience in the launcher.
,
Aug 1
Is this with the new launcher flags enabled?
,
Aug 1
No flags enabled.
,
Aug 6
Not really sure what you're seeing. I'm not seeing this with ChromeVox on trunk. - type "david" 1. Search+Right 2. right arrow result: 1 and 2 traverse through the same elements.
,
Aug 6
Depending on how fresh your trunk is, you could have the new launcher redesign enabled by default. I'd reccomend attempting to fix this with the new flags enabled.
,
Aug 6
#enable-home-launcher #enable-new-style-launcher
,
Aug 6
It looks like for whatever reason, on this device only, ChromeVox gets enabled twice.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725ceedaadb5a568547c6ced8d58a4cc727e2998 commit 725ceedaadb5a568547c6ced8d58a4cc727e2998 Author: David Tseng <dtseng@chromium.org> Date: Tue Aug 07 20:13:08 2018 Always build ChromeVox as compressed js ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. Bug: 868579 Test: clean build for 1. prior to this patch 2. after this patch Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 Reviewed-on: https://chromium-review.googlesource.com/1165787 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581325} [modify] https://crrev.com/725ceedaadb5a568547c6ced8d58a4cc727e2998/chrome/browser/resources/chromeos/chromevox/BUILD.gn
,
Aug 7
Can someone other than me verify? Thanks!
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9871f52a9f384415409c2e6a61d8d477b796bae6 commit 9871f52a9f384415409c2e6a61d8d477b796bae6 Author: Avi Drissman <avi@chromium.org> Date: Wed Aug 08 15:15:28 2018 Revert "Always build ChromeVox as compressed js" This reverts commit 725ceedaadb5a568547c6ced8d58a4cc727e2998. Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg chromevox test: BackgroundTest.NavigationEscapesEdit interactive_ui_tests TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 LoggedInSpokenFeedbackTest.KeyboardShortcutViewer TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 GuestSpokenFeedbackTest.FocusToolbar Original change's description: > Always build ChromeVox as compressed js > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > Bug: 868579 > Test: clean build for > 1. prior to this patch > 2. after this patch > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > Reviewed-on: https://chromium-review.googlesource.com/1165787 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581325} TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1167442 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581564} [modify] https://crrev.com/9871f52a9f384415409c2e6a61d8d477b796bae6/chrome/browser/resources/chromeos/chromevox/BUILD.gn
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a173bcea40f963054d5ac1cde93fe363d0dbd5bd commit a173bcea40f963054d5ac1cde93fe363d0dbd5bd Author: David Tseng <dtseng@chromium.org> Date: Wed Aug 08 17:19:04 2018 Reland "Always build ChromeVox as compressed js" This reverts commit 9871f52a9f384415409c2e6a61d8d477b796bae6. Reason for revert: <INSERT REASONING HERE> Was not the culprit of failing chromeos dbg SpokenFeedbackTests. Original change's description: > Revert "Always build ChromeVox as compressed js" > > This reverts commit 725ceedaadb5a568547c6ced8d58a4cc727e2998. > > Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg > > chromevox test: > BackgroundTest.NavigationEscapesEdit > > interactive_ui_tests > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 > LoggedInSpokenFeedbackTest.KeyboardShortcutViewer > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 > GuestSpokenFeedbackTest.FocusToolbar > > > Original change's description: > > Always build ChromeVox as compressed js > > > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > > > Bug: 868579 > > Test: clean build for > > 1. prior to this patch > > 2. after this patch > > > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > > Reviewed-on: https://chromium-review.googlesource.com/1165787 > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581325} > > TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868579 > Reviewed-on: https://chromium-review.googlesource.com/1167442 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581564} TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1167604 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581609} [modify] https://crrev.com/a173bcea40f963054d5ac1cde93fe363d0dbd5bd/chrome/browser/resources/chromeos/chromevox/BUILD.gn
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5d59ec86d0232d95b4baad118cce214b22f0c66 commit b5d59ec86d0232d95b4baad118cce214b22f0c66 Author: David Tseng <dtseng@chromium.org> Date: Wed Aug 08 20:28:57 2018 Revert "Reland "Always build ChromeVox as compressed js"" This reverts commit a173bcea40f963054d5ac1cde93fe363d0dbd5bd. Reason for revert: <INSERT REASONING HERE> Still hunting chromeos dbg failures. Original change's description: > Reland "Always build ChromeVox as compressed js" > > This reverts commit 9871f52a9f384415409c2e6a61d8d477b796bae6. > > Reason for revert: <INSERT REASONING HERE> > Was not the culprit of failing chromeos dbg SpokenFeedbackTests. > > > Original change's description: > > Revert "Always build ChromeVox as compressed js" > > > > This reverts commit 725ceedaadb5a568547c6ced8d58a4cc727e2998. > > > > Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg > > > > chromevox test: > > BackgroundTest.NavigationEscapesEdit > > > > interactive_ui_tests > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 > > LoggedInSpokenFeedbackTest.KeyboardShortcutViewer > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 > > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 > > GuestSpokenFeedbackTest.FocusToolbar > > > > > > Original change's description: > > > Always build ChromeVox as compressed js > > > > > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > > > > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > > > > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > > > > > Bug: 868579 > > > Test: clean build for > > > 1. prior to this patch > > > 2. after this patch > > > > > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > > > > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > > > Reviewed-on: https://chromium-review.googlesource.com/1165787 > > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > > Commit-Queue: David Tseng <dtseng@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#581325} > > > > TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > > > Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 868579 > > Reviewed-on: https://chromium-review.googlesource.com/1167442 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Avi Drissman <avi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581564} > > TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868579 > Reviewed-on: https://chromium-review.googlesource.com/1167604 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581609} TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: I8beec8a3003a2a7254fb987650410bd7289b4478 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1168042 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581683} [modify] https://crrev.com/b5d59ec86d0232d95b4baad118cce214b22f0c66/chrome/browser/resources/chromeos/chromevox/BUILD.gn |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by oxyflush@google.com
, Jul 27