Fix Touch ID attestation statement |
||||||
Issue descriptionThe Touch ID authenticator currently claims to use 'u2f' attestation statement format, when it really wants to use 'packed'.
,
Aug 1
,
Aug 1
,
Aug 1
Pls apply appropriate OSs label.
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
Pls merge to M69 branch 3497 ASAP. Thank you.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba41bf8405450227b7ef580e40bbba1662efdc45 commit ba41bf8405450227b7ef580e40bbba1662efdc45 Author: Martin Kreichgauer <martinkr@google.com> Date: Thu Aug 02 21:30:33 2018 [Merge M69]device/fido: fix attestation format used in Touch ID TouchIdAuthenticator was using FidoAttestationStatement, which is fido-u2f, when it should have been using packed format. This adds a PackedAttestationStatement class and changes the Touch ID code to use it. (cherry picked from commit 43debfd7d6cdb16ba2bf2c5226eeaa85d7c5387e) Bug: 868571 , 678128 Change-Id: I84626df6299d4d9df44500dcbbba365e9a30f2a2 Reviewed-on: https://chromium-review.googlesource.com/1153849 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579131} Reviewed-on: https://chromium-review.googlesource.com/1161252 Cr-Commit-Position: refs/branch-heads/3497@{#354} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/BUILD.gn [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/BUILD.gn [rename] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/attestation_statement_formats.cc [add] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/attestation_statement_formats.h [add] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/attestation_statement_formats_unittest.cc [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/authenticator_make_credential_response.cc [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/ctap_response_unittest.cc [delete] https://crrev.com/39157691ae59c1eb8d145cc17ecd2f2d3ec11d8d/device/fido/fido_attestation_statement.h [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/fido_test_data.h [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/mac/make_credential_operation.mm [modify] https://crrev.com/ba41bf8405450227b7ef580e40bbba1662efdc45/device/fido/mac/util.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 30