Prevent upload of Elo/JCB cards to Google Payments |
||||||
Issue descriptionGoogle Payments doesn't sync Elo/JCB cards to Chrome because they have a very high unmasking failure rate. As a result, Chrome doesn't know about Elo/JCB cards the user has in Payments, and will continually offer to save any Elo/JCB cards it comes across even if the card has been saved before. The goal of this bug is to create a flag lever that disallows uploading of Elo/JCB cards until a more long-term solution is completed.
,
Aug 2
Functionality and metrics have been tested successfully in Canary; officially requesting merge to M69. This will mitigate user-visible problems as upload credit card save expands towards Brazil/Japan. Without this, users can be prompted to upload save a credit card repeatedly, even if the card is already in Google Payments. With this, Chrome can know to avoid uploading Elo/JCB cards entirely until future projects make them syncable again. +durgapandey to decide whether this needs to follow the official "fast-tracking process" with a full launch bug and etc.
,
Aug 2
This bug requires manual review: Less than 29 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
http://crbug.com/868566 is also important in the context of this change, and I've requested merge for that as well (that one is more of an actual bugfix though).
,
Aug 3
Re #2: Could you pls point the launch bug for this? Also is this feature behind finch?
,
Aug 3
This feature is indeed behind Finch feature flags. I don't have a launch bug just yet; will create one upon discussing with durgapandey@ tomorrow.
,
Aug 3
Per the new Chrome launch process, https://docs.google.com/document/d/1hJ1U8-7DNa7lGfTJWRgSgqQyNnOFO4Ks5Czr1-3--8I/edit# I'm assuming we don't need a launch bug for this since it's a bug fix. Krishna can you pls confirm?
,
Aug 3
Is this fall under "bug fixes or other trivial changes"? If yes, then no launch bug is needed. +durgapandey@.
,
Aug 3
Yes it does, thanks.
,
Aug 3
Approving merge to M69 branch 3497 based on comment #2, #6, #7, #8, #9 and per internal email thread and offline chat with durgapandey@. This is self-contained and Finch flag-protected change.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/031d2afc688703957aa0c21f0534e1d82d32d176 commit 031d2afc688703957aa0c21f0534e1d82d32d176 Author: sebsg <sebsg@chromium.org> Date: Fri Aug 03 21:22:12 2018 Merge-69 [AF] Allow for blocking Elo/JCB cards from credit card upload TBR=jsaul@google.com (cherry picked from commit 085d2f35fd61a638d9f61a658627bd46c67a8793) Bug: 868552 Change-Id: Iac64b875611994439dae09d65ff7c999cde74ff8 Reviewed-on: https://chromium-review.googlesource.com/1153301 Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Original-Commit-Position: refs/heads/master@{#579908} Reviewed-on: https://chromium-review.googlesource.com/1162759 Cr-Commit-Position: refs/branch-heads/3497@{#395} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/browser/form_data_importer.cc [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/components/autofill/core/common/autofill_features.h [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/tools/metrics/histograms/enums.xml [modify] https://crrev.com/031d2afc688703957aa0c21f0534e1d82d32d176/tools/metrics/histograms/histograms.xml
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54b9aad4c54cab45b206fdec5d8a2168725f3884 commit 54b9aad4c54cab45b206fdec5d8a2168725f3884 Author: Jared Saul <jsaul@google.com> Date: Mon Aug 06 22:29:33 2018 [Autofill] Enable 'Disallow Elo/JCB' features for waterfall testing config Bug: 868552 Change-Id: I6a796cdcc0d4aa27750caa8a93581f205d4e8409 Reviewed-on: https://chromium-review.googlesource.com/1161569 Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#581011} [modify] https://crrev.com/54b9aad4c54cab45b206fdec5d8a2168725f3884/testing/variations/fieldtrial_testing_config.json
,
Nov 6
Are you intending to fix this in the code itself as well, or rely on Finch for the foreseeable future?
,
Nov 6
Intend to rely on Finch for this for a while. It's currently unclear if the upcoming Autofill Auth project will allow us to start saving Elo/JCB cards again, so seems better to avoid cleaning this up if we might revert it later. Let me close this bug since it's launched, and create a new one for the cleanup of this code. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 1