New issue
Advanced search Search tips

Issue 868542 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up usage of BreakDebugger so that crashes are consistent

Project Member Reported by torne@chromium.org, Jul 27

Issue description

See issue 851851 and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/W7YNqPabRm4/discussion for background.

The various places in the codebase that implement "crash here on purpose", such as CHECK, DCHECK, NOTREACHED, LOG(FATAL), and others, currently aren't all consistent with each other about exactly how they crash, which can result in surprising results like issue 851851, where LOG(FATAL) crashes were not symbolising correctly on the crash server due to a code generation change, but other crashes were still working as expected.

LOG(FATAL) has now been made consistent with CHECK() in that issue, but it would be good to tidy up any remaining inconsistencies and document clearly which way of crashing is supposed to be used for what, as well as clarify the existing somewhat outdated comments in BreakDebugger.
 

Sign in to add a comment