Issue metadata
Sign in to add a comment
|
[autofill] Cleanups not triggered for signed-out users |
||||||||||||||||||||||
Issue descriptionThe autofill data fixups (dedupe, deleting disused data, etc) are triggered too early for non-signed-in-and-syncing users. All the local autofill data needs to be loaded to the personal data manager before they are triggered.
,
Aug 3
,
Aug 7
,
Aug 7
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7
Could you pls provide merge justification for this? How safe it is and why it is needed for M69?
,
Aug 7
Background: For non-signed-in users, this change moves the triggering of some maintenance tasks to occur after the initial loading of autofill data from its database instead of on sync init in disabled state. The timing of the sync init seems to have changed from when the hooks were initially added; they now trigger too early, before the data on which they act has been loaded. This affects the on-version-upgrade deduplication of profiles along with some other profile cleanups we wanted to launch in M69. We have limited UMA data, but so far it looks to be safe. https://uma.googleplex.com/p/chrome/variations/?sid=ae165fb76ae9cab9bcef157ebbcb5d92 +durgapandey for additional comments.
,
Aug 7
Thank you rogerm@. I will wait for durgapandey@'s comments.
,
Aug 7
Krishna, this is a bug fix for a broken cleanup flow we have today for non-signed-in-and-syncing users. It's a pretty narrow change and an important fix - we should merge this in M69.
,
Aug 7
Approving merge to M69 branch 3497 based on comment #6, #7 and per offline chat with durgapandey@. Please merge before 1:00 PM PT tomorrow, Wednesday so we can pick it up for this week Beta release. Thank you.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adf599d866c9a28e6f95af16ed4e2c674e4fc2fd commit adf599d866c9a28e6f95af16ed4e2c674e4fc2fd Author: Roger McFarlane <rogerm@chromium.org> Date: Wed Aug 08 00:44:26 2018 [autofill] Move fixups to be invoked after initial database load Bug: 868533 Change-Id: Ieb2d140b7293de20e6c53f6ab497308b4df7dc0f Reviewed-on: https://chromium-review.googlesource.com/1153665 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579414}(cherry picked from commit 2e1e4f1b27a8a4a8446d26d96672af6e5b57bd84) Reviewed-on: https://chromium-review.googlesource.com/1166402 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#481} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/adf599d866c9a28e6f95af16ed4e2c674e4fc2fd/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/adf599d866c9a28e6f95af16ed4e2c674e4fc2fd/components/autofill/core/browser/personal_data_manager_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 31