skylab_suite: task expiration is too short |
|||
Issue descriptionThe task expiration timeout used by skylab_suite is 30 seconds. This basically means that if each of the tasks in the suite doesn't immediately get a DUT, it will expire. How is this not a problem in prod? This is making push_to_prod suite fail because there aren't enough DUTs for each task in the suite.
,
Jul 30
I only pass 180S as provision expiration seconds since I don't want provision to wait for too long. I'm afraid if it's too long it will add too much overhead to provision suite. How long do you suggest? For normal suite, I don't think the 30s setting is actually used.
,
Jul 31
Currently, all suites are created with expiration seconds = 30 https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/venv/skylab_suite/cros_suite.py?l=345 In fact, I don't see where you're creating provision suite with expiration_seconds set to 180 Also, why do you worry about task expiration in case of provision suite. Isn't the provision suite supposed to active wait for m < n tasks to succeed and then declare success?
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/08354a0c73ae4cb704d0594c3d5ac2865aaa4198 commit 08354a0c73ae4cb704d0594c3d5ac2865aaa4198 Author: Xixuan Wu <xixuan@chromium.org> Date: Thu Aug 02 23:02:19 2018 autotest: Pass suite_name to Handler and use it to determine a provision suite. BUG= chromium:868528 TEST=None Change-Id: I3ef91968d15aa23f6af1972ea12cb7f4173537a4 Reviewed-on: https://chromium-review.googlesource.com/1158847 Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/08354a0c73ae4cb704d0594c3d5ac2865aaa4198/venv/skylab_suite/cros_suite.py [modify] https://crrev.com/08354a0c73ae4cb704d0594c3d5ac2865aaa4198/venv/skylab_suite/cmd/run_suite_skylab.py
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6bd67eaa6bb27f610e1902e992e5c6e07a703e78 commit 6bd67eaa6bb27f610e1902e992e5c6e07a703e78 Author: Xixuan Wu <xixuan@chromium.org> Date: Thu Aug 02 23:03:31 2018 autotest: Extend expiration_seconds for all tasks to 10 mins. BUG= chromium:868528 TEST=None Change-Id: I4a4f5e6c73888678396bf5f33cb0721c4b3c6fd6 Reviewed-on: https://chromium-review.googlesource.com/1158851 Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/6bd67eaa6bb27f610e1902e992e5c6e07a703e78/venv/skylab_suite/swarming_lib.py [modify] https://crrev.com/6bd67eaa6bb27f610e1902e992e5c6e07a703e78/venv/skylab_suite/cros_suite.py
,
Aug 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pprabhu@chromium.org
, Jul 27