Issue metadata
Sign in to add a comment
|
77.7%-86.6% regression in blink_perf.layout at 577815:577923 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/13f7432da40000
,
Jul 28
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/13f7432da40000 win: Attempt to fix compile in branded builds. by thakis@chromium.org https://chromium.googlesource.com/chromium/src/+/1a0c7ebc9a25ca0e51cadcfb6912e9011c0109e5 9216 → 9365 (+149.2) [css-grid] New list-based data structure for the Grid by svillar@igalia.com https://chromium.googlesource.com/chromium/src/+/b9351e20a47f21d28527b55d49e2191f0a08845f 9279 → 2060 (-7219) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 29
My commit is a compile fix. If the perf bots do official builds then they couldn't build for a while before that fix, but then they should attribute the regression to all changes that landed since the last successful compile, not just to that.
,
Jul 30
This was expected. Inserting a large item is the worst case scenario for the new list-based grid data structure. We precisely landed this new test in order to track this regression. It should not affect real life use cases though.
,
Jul 30
If it is expected and acceptable feel free to close as wontfix. If there is still work being done to improve the worst-case scenario then please reference that bug as a blocking bug for this one.
,
Jul 30
,
Aug 6
Closing then as WONTFIX. It was already expected to have this regression, because it's an artificial test testing the worst case scenario for the new list based data structure for grids. The previous vector-based implementation was pretty fast inserting new items but very greedy memory-wise. The new one has great memory savings for huge sparse grids but it's slower on this rare use cases. That's a trade off as usual between memory and performance. Knowing that, we decided to land the perf test before landing the new data structure to keep track of the regression.
,
Aug 13
Issue 868972 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 27