New issue
Advanced search Search tips

Issue 868511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Switch to Open Tab: Right arrow (at end of row) should highlight button

Project Member Reported by emilyschechter@chromium.org, Jul 27

Issue description

in omnibox Switch to Open Tab suggestion, when the cursor is at the end of the test row (i.e. default when arrowing down through the list), right arrow key should highlight button
 
Cc: k...@chromium.org
Owner: k...@chromium.org
Status: Assigned (was: Untriaged)
I can confirm that it doesn't do that presently. Sending to krb as a feature request.
Just documenting some previous observations in this bug: It is inconsistent that right arrow would move the focus within the Omnibox pop-up. If the cursor were in the middle of the Omnibox text and the user hit right arrow until it reached the end, and then saw focus change somewhere else, that would be quite unexpected.

Additionally, what would the user expect left arrow to do at this point? Unfocus the button or (as I believe it should) move the cursor within the Omnibox?

Yeah, those are good questions. Let's discuss further in person.
Labels: Group-Omnibox
Owner: emilyschechter@chromium.org
On further reflection, I'm back to thinking we can't do this. Not without time to think deeper about how to do it nand try it out and iterate on how it works.

We could *maybe* put the button in the up/down arrow order. That's a lot more straightforward.

Back to emilyschechter for thoughts on this.
I don't think up/down makes sense contextually for users and it would be more confusing. We can discuss this at the OB sync today.

Re c#3, I think left arrow would first unfocus, then move within omnibox.
Cc: emilyschechter@chromium.org
Owner: k...@chromium.org
krb has a WIP CL to add this behavior.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b37e4f20abe5faeaa7b8a5e116e20ee2eeaefc5

commit 8b37e4f20abe5faeaa7b8a5e116e20ee2eeaefc5
Author: Kevin Bailey <krb@chromium.org>
Date: Tue Aug 28 23:47:21 2018

[omnibox] Left/right arrow keys focus tab switch button

Left and right arrow keys currently move the cursor within the Omnibox
(text field). (Up and down change the selected suggestion.) This change
allows the right arrow key to focus the tab switch button when the
cursor is already at the end of the text field (and there is a tab
switch button on the selected line ready to be focused.)

Bug:  868511 
Change-Id: Ie708f8c4f04386a38c94da9932edecf7b5ee7b44
Reviewed-on: https://chromium-review.googlesource.com/1172725
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586937}
[modify] https://crrev.com/8b37e4f20abe5faeaa7b8a5e116e20ee2eeaefc5/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/8b37e4f20abe5faeaa7b8a5e116e20ee2eeaefc5/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/8b37e4f20abe5faeaa7b8a5e116e20ee2eeaefc5/components/omnibox/browser/omnibox_popup_model.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2b21bc28e4b93a6e262eb7a2afd4205ef57e413

commit d2b21bc28e4b93a6e262eb7a2afd4205ef57e413
Author: Kevin Bailey <krb@chromium.org>
Date: Thu Aug 30 13:08:53 2018

[omnibox] Clean up arrow key handling

I missed a call to new function SelectionAtEnd(), and new function
could be implemented in a manner more consistent with the rest of
the file.

Bug:  868511 
Change-Id: Ic5cfaba9ad4413ba5a9f7b311468ba11cd8037b6
Reviewed-on: https://chromium-review.googlesource.com/1195642
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587541}
[modify] https://crrev.com/d2b21bc28e4b93a6e262eb7a2afd4205ef57e413/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Labels: TE-Verified-M70 TE-Verified-70.0.3537.0
Able to reproduce the issue on build without fix #68.0.3440.84 using Windows 7 as per comment #0.

Verified the fix on Mac 10.13.3,Windows 7 and Ubuntu 17.10 as per comment#0 on chrome version #70.0.3537.0.
Attaching screen cast for reference.
Observed that in the suggestion box when the cursor is at the end of the test row and right arrow from keyboard is clicked it highlightes 'Switch to Open Tab'.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!
868511.mp4
410 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment