New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868504 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Android OOP-D: Add OverlayCandidateValidator to GLOutputSurfaceAndroid

Project Member Reported by ericrk@chromium.org, Jul 27

Issue description

We used a custom OverlayCandidateValidator for AndroidOutputSurface, but this was not brought over to GLOutputSurfaceAndroid. This could lead to
incorrect overlay decisions on Android.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50bf9fc214b002b57ace4f742718e51fdff70522

commit 50bf9fc214b002b57ace4f742718e51fdff70522
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Jul 30 23:30:12 2018

Android OOP-D: Add overlay candidate validator to GLOutputSurfaceAndroid

We had a custom OverlayCandidateValidator for AndroidOutputSurface, but
this was missing from GLOutputSurfaceAndroid.

Bug:  868504 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9a7b58575378d8c516b10dba04df8f80a2ccf77d
Reviewed-on: https://chromium-review.googlesource.com/1153604
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579232}
[modify] https://crrev.com/50bf9fc214b002b57ace4f742718e51fdff70522/components/viz/service/display_embedder/gl_output_surface_android.cc
[modify] https://crrev.com/50bf9fc214b002b57ace4f742718e51fdff70522/components/viz/service/display_embedder/gl_output_surface_android.h

Labels: Merge-Request-69
Labels: M-68
This is a small change which causes GLOutputSurfaceAndroid to match CompositorImpl::AndroidOutputSurface.

We missed this during M68, and without it we will likely have different overlay decisions in Viz vs. non-Viz, which could lead to issues.

Would like to merge to M68 to prevent these issues - this change is very safe as it only affects the VizDisplayCompositor path, and if we find issues with this path during beta we can disable via Finch.
Labels: -M-68 M-69
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 1

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044

commit 8f22effb68ff1e2c4d3476c7e7bc199c43b5f044
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Aug 01 17:04:45 2018

Android OOP-D: Add overlay candidate validator to GLOutputSurfaceAndroid

We had a custom OverlayCandidateValidator for AndroidOutputSurface, but
this was missing from GLOutputSurfaceAndroid.

TBR=ericrk@chromium.org

(cherry picked from commit 50bf9fc214b002b57ace4f742718e51fdff70522)

Bug:  868504 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9a7b58575378d8c516b10dba04df8f80a2ccf77d
Reviewed-on: https://chromium-review.googlesource.com/1153604
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579232}
Reviewed-on: https://chromium-review.googlesource.com/1158862
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#314}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044/components/viz/service/display_embedder/gl_output_surface_android.cc
[modify] https://crrev.com/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044/components/viz/service/display_embedder/gl_output_surface_android.h

Status: Fixed (was: Started)

Sign in to add a comment