Android OOP-D: Add OverlayCandidateValidator to GLOutputSurfaceAndroid |
|||||||
Issue descriptionWe used a custom OverlayCandidateValidator for AndroidOutputSurface, but this was not brought over to GLOutputSurfaceAndroid. This could lead to incorrect overlay decisions on Android.
,
Jul 31
,
Jul 31
This is a small change which causes GLOutputSurfaceAndroid to match CompositorImpl::AndroidOutputSurface. We missed this during M68, and without it we will likely have different overlay decisions in Viz vs. non-Viz, which could lead to issues. Would like to merge to M68 to prevent these issues - this change is very safe as it only affects the VizDisplayCompositor path, and if we find issues with this path during beta we can disable via Finch.
,
Jul 31
,
Aug 1
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044 commit 8f22effb68ff1e2c4d3476c7e7bc199c43b5f044 Author: Eric Karl <ericrk@chromium.org> Date: Wed Aug 01 17:04:45 2018 Android OOP-D: Add overlay candidate validator to GLOutputSurfaceAndroid We had a custom OverlayCandidateValidator for AndroidOutputSurface, but this was missing from GLOutputSurfaceAndroid. TBR=ericrk@chromium.org (cherry picked from commit 50bf9fc214b002b57ace4f742718e51fdff70522) Bug: 868504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9a7b58575378d8c516b10dba04df8f80a2ccf77d Reviewed-on: https://chromium-review.googlesource.com/1153604 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579232} Reviewed-on: https://chromium-review.googlesource.com/1158862 Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#314} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044/components/viz/service/display_embedder/gl_output_surface_android.cc [modify] https://crrev.com/8f22effb68ff1e2c4d3476c7e7bc199c43b5f044/components/viz/service/display_embedder/gl_output_surface_android.h
,
Aug 14
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jul 30