New issue
Advanced search Search tips

Issue 868502 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

add ESLint and prettier presubmit checks for JS

Project Member Reported by seanmccullough@chromium.org, Jul 27

Issue description

These checks can probably be called from https://cs.chromium.org/chromium/infra/PRESUBMIT.py

but may need some library support. See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for (what may be outdated) docs on how that system works.

At a bare minimum it should check for local eslint settings in whatever directory it's invoked from, but it's probably a good idea to have a global default settings file.

Start out with warnings rather than failing the presubmit check.


 
We appear to run jshint already on some files as part of presubit: https://cs.chromium.org/chromium/infra/PRESUBMIT.py?sq=package:chromium&q=infra+presubmit.py&l=335

Might be able to use that as a model for running node on presubmit.
Cc: -eakuefner@chromium.org

Sign in to add a comment