New issue
Advanced search Search tips

Issue 868501 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Rename blink/common/message_port and blink/public/mojom/message_port to messaging

Project Member Reported by mek@chromium.org, Jul 27

Issue description

For consistency with blink/renderer/core/messaging and the bug component (and just because it makes more sense) these directories should probably be renamed to just "messaging" as well. And message_port.mojom also isn't really anything message port specific, and could probably be split in cloneable_message.mojom and transferable_message.mojom.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8

commit 47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Sep 06 02:13:40 2018

Rename message_port directories to messaging.

Rename blink/common/message_port/, blink/public/common/message_port/
and blink/public/mojom/message_port/ to messaging/.

Bug:  868501 
Change-Id: I2e657863803bb0a2c80baff970618075397c18b3
Reviewed-on: https://chromium-review.googlesource.com/1203753
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589087}
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/chrome/browser/chromeos/android_sms/connection_establisher_impl.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/chrome/browser/chromeos/android_sms/connection_establisher_impl_unittest.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/android/app_web_message_port.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/android/app_web_message_port.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/message_port_provider.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/mock_shared_worker.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/shared_worker_connector_impl.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/shared_worker_host_unittest.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/common/content_param_traits.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/common/frame_messages.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/renderer/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/BUILD.gn
[delete] https://crrev.com/d4f9bbd56e958e973205b04288c90d790c23afdc/third_party/blink/common/message_port/cloneable_message.typemap
[delete] https://crrev.com/d4f9bbd56e958e973205b04288c90d790c23afdc/third_party/blink/common/message_port/transferable_message.typemap
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/OWNERS
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/cloneable_message.cc
[add] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/cloneable_message.typemap
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/cloneable_message_struct_traits.cc
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/cloneable_message_struct_traits.h
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/message_port_channel.cc
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/string_message_codec.cc
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/string_message_codec_unittest.cc
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/transferable_message.cc
[add] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/transferable_message.typemap
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/transferable_message_struct_traits.cc
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/messaging/transferable_message_struct_traits.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/common/typemaps.gni
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/BUILD.gn
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/messaging/OWNERS
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/messaging/cloneable_message.h
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/messaging/message_port_channel.h
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/messaging/string_message_codec.h
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/common/messaging/transferable_message.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/messaging/OWNERS
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/messaging/message_port.mojom
[rename] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/messaging/user_activation_snapshot.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/service_worker/service_worker.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/mojom/service_worker/service_worker_object.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/platform/modules/broadcastchannel/broadcast_channel.mojom
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/platform/modules/service_worker/web_service_worker.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider_client.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/public/web/web_dom_message_event.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_cloneable_message.typemap
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_cloneable_message_struct_traits.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_transferable_message.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_transferable_message.typemap
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits_test.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/messaging/message_port.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc
[modify] https://crrev.com/47ed0fc53d15470d39c51cfbf5b06933e2ffcfd8/third_party/blink/renderer/platform/cross_thread_copier.h

Owner: zhuoyu.q...@samsung.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b647e77c1dccf83dd3b1cb091530fb0c5badd543

commit b647e77c1dccf83dd3b1cb091530fb0c5badd543
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Sep 19 04:04:47 2018

Split message_port.mojom into two mojoms.

The message_port.mojom isn't really anything message port specific, split it in
cloneable_message.mojom and transferable_message.mojom.

Bug:  868501 
Change-Id: I13b52137162579a62d09ff38ae80459ac8d16c25
Reviewed-on: https://chromium-review.googlesource.com/1207789
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#592316}
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/content/common/content_param_traits.cc
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/common/messaging/cloneable_message.cc
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/common/messaging/cloneable_message.typemap
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/common/messaging/cloneable_message_struct_traits.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/common/messaging/transferable_message.typemap
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/common/messaging/transferable_message_struct_traits.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/common/messaging/transferable_message.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/mojom/messaging/cloneable_message.mojom
[delete] https://crrev.com/da858d822e0245e4bbfaad4486600398a2bf7a59/third_party/blink/public/mojom/messaging/message_port.mojom
[add] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/mojom/messaging/transferable_message.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/mojom/service_worker/service_worker.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/mojom/service_worker/service_worker_object.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/public/platform/modules/broadcastchannel/broadcast_channel.mojom
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_cloneable_message.typemap
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_cloneable_message_struct_traits.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_transferable_message.typemap
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits.cc
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits.h
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/messaging/blink_transferable_message_struct_traits_test.cc
[modify] https://crrev.com/b647e77c1dccf83dd3b1cb091530fb0c5badd543/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.h

I think this issue is fixed, mek@ what do you think?
Status: Fixed (was: Started)
Yes, thanks a lot!

Sign in to add a comment