New issue
Advanced search Search tips

Issue 868497 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Jul 31
Cc:
dmazz...@chromium.org
katie@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 841020



Sign in to add a comment

Make Select-to-speak work in shortcut viewer app

Project Member Reported by jamescook@chromium.org, Jul 27 
The shortcut viewer app runs out-of-process. Right now we fall back to the old non-app shortcut viewer if select-to-speak is enabled.

It looks like the automation extension API hit-test action needs to be implemented for remote apps.

The tricky bit seems to be:
* Clicking in the remote app window results in ash/browser seeing window A getting hit
* But window A isn't the one that has the AX child tree ID associated with it, so the browser doesn't know it's a remote process

I suspect this is yet another problem with how we glue together the aura window/widget/view hierarchy for remote apps.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a60669719422265debce4636de62c32b798e3730

commit a60669719422265debce4636de62c32b798e3730
Author: James Cook <jamescook@chromium.org>
Date: Tue Jul 31 19:34:07 2018

cros: Make a11y select-to-speak work with shortcut viewer mojo app

Wire up a11y hit test actions for remote applications. Select-to-speak
works fine once the hit tests are correct.

Bug:  868497 
Test: added to views_mus_unittests
Change-Id: Ia3dcc4cb7b4c3dcab35f0f20d31d6a5ea71f3ec0
Reviewed-on: https://chromium-review.googlesource.com/1153731
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579527}
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/ash/shell.cc
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/ash/shell.h
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/ui/views/mus/ax_remote_host.cc
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/ui/views/mus/ax_remote_host.h
[modify] https://crrev.com/a60669719422265debce4636de62c32b798e3730/ui/views/mus/ax_remote_host_unittest.cc

Comment 2 by jamescook@chromium.org, Jul 31

Status: Fixed (was: Started)
►

Sign in to add a comment