New issue
Advanced search Search tips

Issue 868479 link

Starred by 2 users
Status: Fixed
Owner:
dnicoara@chromium.org
Closed: Jul 30
Cc:
dnicoara@chromium.org
dcasta...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 869901



Sign in to add a comment

DCHECK failure at ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc

Project Member Reported by bpastene@chromium.org, Jul 27 
The browser crashes on cros VMs due to the following DCHECK failure:
[FATAL:hardware_display_plane_manager_legacy.cc(217)] Check failed: crtc_props.degamma_lut.id || crtc_props.gamma_lut.id.

https://codesearch.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc?rcl=7751fadb5e97f540dd822df3f87aad61ad7b6dd7&l=217

The check looks to be an addition from https://chromium-review.googlesource.com/c/chromium/src/+/1058150, so assigning author.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a530d7a01df9540177687ad345af010b1aefde2

commit 0a530d7a01df9540177687ad345af010b1aefde2
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Fri Jul 27 22:13:37 2018

[OZONE-DRM] If the GAMMA properties aren't available always do legacy API

If we don't have the GAMMA properties try the legacy path even when
trying to disable GAMMA otherwise we could leave the GAMMA set to an
undesirable value.

BUG= 868479 
TEST=New unittest

Change-Id: I61b7c576b4ae09f1a2ad6d8bf837fb01bcd49b79
Reviewed-on: https://chromium-review.googlesource.com/1153599
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578827}
[modify] https://crrev.com/0a530d7a01df9540177687ad345af010b1aefde2/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc
[modify] https://crrev.com/0a530d7a01df9540177687ad345af010b1aefde2/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[modify] https://crrev.com/0a530d7a01df9540177687ad345af010b1aefde2/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/0a530d7a01df9540177687ad345af010b1aefde2/ui/ozone/platform/drm/gpu/mock_drm_device.h

Comment 2 by dnicoara@chromium.org, Jul 30

Status: Fixed (was: Assigned)

Comment 3 by bpastene@chromium.org, Jul 30 

thnx!

Comment 4 by dnicoara@chromium.org, Aug 1

Cc: dnicoara@chromium.org
 Issue 869901  has been merged into this issue.

Comment 5 by achuith@chromium.org, Aug 3

Blocking: 869901
►

Sign in to add a comment