New issue
Advanced search Search tips

Issue 868474 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TBR does not work

Project Member Reported by danakj@chromium.org, Jul 27 
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1145644

Has TBR= line in the description.
Presubmit still fails due to OWNERS.

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    components/BUILD.gn

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939823668749477392/+/steps/presubmit/0/stdout

Comment 1 by no...@chromium.org, Jul 27

Cc: tandrii@chromium.org
Components: -Infra>Platform>Buildbucket>Gerrit Infra>Platform>CQ
wild guess: maybe TBR should be in the bottom because it is officially called CL footer?

Comment 2 by danakj@chromium.org, Jul 27 

I moved it up because I thought maybe it couldn't see it at the bottom.

It seems it's probably because the CL deleted an OWNERS file (though not in the place it is complaining about missing OWNERS)

Comment 3 by tandrii@chromium.org, Jul 30

Cc: -tandrii@chromium.org
Components: -Infra>Platform>CQ Infra>SDK
CQ doesn't care about TBR. This is a problem in depot_tools presubmit support.

Comment 4 by ehmaldonado@chromium.org, Aug 6

Status: Available (was: Untriaged)
►

Sign in to add a comment