New issue
Advanced search Search tips

Issue 868462 link

Starred by 3 users
Status: Fixed
Owner:
mek@chromium.org
Closed: Aug 9
Cc:
jam@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification



Sign in to add a comment

Blobs in IndexedDB are broken with network service enabled.

Project Member Reported by mek@chromium.org, Jul 27 
As mentioned in 859594 it is not possible to store blobs in IDB if network service is enabled. But unfortunately this is not caught in any currently automated tests, as this is only broken with chrome/browser_tests, while it "works" in content_shell/content_browsertests.

But running for example http://web-platform.test:8000/IndexedDB/nested-cloning-small.html in chrome with network service enabled clearly shows that this is broken.

No idea how many other layout tests are broken in chrome currently undetected since we only run them in content_shell...

Comment 1 by mek@chromium.org, Jul 30 

Also related to issue 764130, which has some more background into the ultimately desired layering between IDB and Blobs.

Comment 2 by dxie@google.com, Aug 1

Status: Available (was: Untriaged)

Comment 3 by dxie@google.com, Aug 2

Cc: jam@chromium.org
+jam@, as fyi.

Comment 4 by jam@chromium.org, Aug 3 

Is there a smaller repro? i.e. I don't know how run the test in the link above.

Comment 5 by jam@chromium.org, Aug 3 

Ok nvm, I figured out how to run wpt tests.

I suspect that chrome vs content difference is due to r567879.

Regarding the question in #1, since the goal is to eventually get rid of URLRequestCOntext instantiation in the browser process when network service is enabled, it will find all these cases.

Comment 6 by cmumford@chromium.org, Aug 3

Owner: cmumford@chromium.org
Status: Assigned (was: Available)

Comment 7 by cmumford@chromium.org, Aug 3

Status: Started (was: Assigned)

Comment 8 by cmumford@chromium.org, Aug 3

Status: Assigned (was: Started)

Comment 9 by cmumford@chromium.org, Aug 6

Status: Started (was: Assigned)

Comment 10 by mek@chromium.org, Aug 6

Owner: mek@chromium.org
as discussed offline, stealing this one, even though I said I wasn't going to work on it earlier...
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a780469e2f2de600512c592c36041002dd697a33

commit a780469e2f2de600512c592c36041002dd697a33
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Aug 09 04:59:33 2018

[FileSystem]: Rewrite FileWriterDelegate using BlobReader rather than URLRequest.

Not perfect, since this really should be going through the mojo interface
for dealing with blobs, but a lot better than going through blob URLs.

Tbr: reillyg@chromium.org
Bug:  859594 ,  868462 , 804546
Change-Id: Ifd7cd11b7bf4432eff41bdef00edd079d31e49c6
Reviewed-on: https://chromium-review.googlesource.com/1164523
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581790}
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/canned_syncable_file_system.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/chrome/browser/sync_file_system/local/syncable_file_system_operation.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/fileapi/fileapi_message_filter.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/fileapi/fileapi_message_filter.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/fileapi/fileapi_message_filter_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_blob_info.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_blob_info.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation_impl.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation_impl.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation_runner.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_system_operation_runner.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_writer_delegate.cc
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_writer_delegate.h
[modify] https://crrev.com/a780469e2f2de600512c592c36041002dd697a33/storage/browser/fileapi/file_writer_delegate_unittest.cc

Comment 12 by mek@chromium.org, Aug 9

Status: Fixed (was: Started)

Comment 13 by jam@chromium.org, Aug 10 

Thanks Marijn!
►

Sign in to add a comment