New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868461 link

Starred by 1 user
Status: Fixed
Owner:
bajones@chromium.org
Closed: Jul 31
Cc:
█ jmedley@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-VR



Sign in to add a comment

[WebXR] Use XRRay type or input target rays

Project Member Reported by bajones@chromium.org, Jul 27 
Change was described in https://github.com/immersive-web/webxr/pull/357

The pointerMatrix in XRInputPose (which is actually already outdated and should have been targetRayMatrix) should be updated to an XRRay type. The XRRay continues to provide a transformation matrix that reports the same value as before, but additionally reports the ray origin and direction as DOMPointReadOnlys.

Comment 1 by btebbs@chromium.org, Jul 30

Components: Blink>WebXR
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8736d7817c4ec96e7236508e13c31850fa80eb3f

commit 8736d7817c4ec96e7236508e13c31850fa80eb3f
Author: Brandon Jones <bajones@chromium.org>
Date: Tue Jul 31 00:45:58 2018

Added XRRay type, converted XRInputPose to use it.

New type provides origin and direction for the ray as DOMPointReadOnly
values.

Bug:  868461 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I918d8cad2569919b3d159eb910da4dddb31d3562
Reviewed-on: https://chromium-review.googlesource.com/1153475
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579264}
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[add] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/WebKit/LayoutTests/xr/getInputPose_ray.html
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/BUILD.gn
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_input_pose.cc
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_input_pose.h
[modify] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_input_pose.idl
[add] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_ray.cc
[add] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_ray.h
[add] https://crrev.com/8736d7817c4ec96e7236508e13c31850fa80eb3f/third_party/blink/renderer/modules/xr/xr_ray.idl

Comment 3 by bajones@chromium.org, Jul 31

Labels: Merge-Request-69
Status: Fixed (was: Assigned)
Would like to merge this into M69 if possible so the API we present for an upcoming origin trial is more consistent.

Comment 4 by ddorwin@chromium.org, Jul 31

Cc: jmedley@chromium.org
Components: -Blink>WebVR
Labels: XR-Spec

Comment 5 by bajones@chromium.org, Jul 31

Labels: -Pri-3 Pri-2
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Aug 1 

Pls merge your change to M69 branch 3497 ASAP. Thank you.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 1

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd

commit 1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd
Author: Brandon Jones <bajones@chromium.org>
Date: Wed Aug 01 17:38:51 2018

Added XRRay type, converted XRInputPose to use it.

New type provides origin and direction for the ray as DOMPointReadOnly
values.

TBR=bajones@chromium.org

(cherry picked from commit 8736d7817c4ec96e7236508e13c31850fa80eb3f)

Bug:  868461 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I918d8cad2569919b3d159eb910da4dddb31d3562
Reviewed-on: https://chromium-review.googlesource.com/1153475
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579264}
Reviewed-on: https://chromium-review.googlesource.com/1158983
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#316}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[add] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/WebKit/LayoutTests/xr/getInputPose_ray.html
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/BUILD.gn
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_input_pose.cc
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_input_pose.h
[modify] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_input_pose.idl
[add] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_ray.cc
[add] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_ray.h
[add] https://crrev.com/1ab16e9803e643eb4bbb48bcd4f7a4230d401ddd/third_party/blink/renderer/modules/xr/xr_ray.idl
►

Sign in to add a comment