New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868449 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Aug 2
Cc:
█ apaci...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: window play/pause state goes out of sync after reload and no preload

Project Member Reported by mlamouri@chromium.org, Jul 27 
Chrome Version       : 70.0.3504.0
OS Version: Mac
URLs (if applicable) : https://www.html5rocks.com/en/tutorials/video/basics/

What steps will reproduce the problem?
1. Start PIP
2. Play
3. Stop PIP from menu
4. Reload page
5. Start PIP

What is the expected result?
PIP window shows a play button

What happens instead of that?
PIP window shows a pause button

Comment 1 by mlamouri@chromium.org, Jul 27

Components: Blink>Media>PictureInPicture

Comment 2 by mlamouri@chromium.org, Jul 27

Status: Started (was: Assigned)
CL uploaded for review.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2

commit 118bcd191075a58171f2b3c2e74d5ee0ae77a9a2
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jul 30 15:59:28 2018

Picture-in-Picture: set playback state when setting a new surface.

When EmbedSurface() is called, always check the playback state of the
associated media player if there is one so we can guarantee that the
Picture-in-Picture window matches the current known state.

Bug:  868449 
Change-Id: Iad61dcc67d5b6f4acc75dc5490883ea9733e75ad
Reviewed-on: https://chromium-review.googlesource.com/1153464
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579052}
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/118bcd191075a58171f2b3c2e74d5ee0ae77a9a2/ui/views/controls/button/image_button.h

Comment 4 by mlamouri@chromium.org, Jul 30

Labels: Merge-Request-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b503c7f2f14987505aa69bd0812891f8ed4b76e2

commit b503c7f2f14987505aa69bd0812891f8ed4b76e2
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jul 31 17:26:31 2018

Picture-in-Picture: set playback state when setting a new surface.

When EmbedSurface() is called, always check the playback state of the
associated media player if there is one so we can guarantee that the
Picture-in-Picture window matches the current known state.

Bug:  868449 
Change-Id: Iad61dcc67d5b6f4acc75dc5490883ea9733e75ad
Reviewed-on: https://chromium-review.googlesource.com/1153464
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579052}(cherry picked from commit 118bcd191075a58171f2b3c2e74d5ee0ae77a9a2)
Reviewed-on: https://chromium-review.googlesource.com/1156765
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#280}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/b503c7f2f14987505aa69bd0812891f8ed4b76e2/ui/views/controls/button/image_button.h

Comment 7 by mlamouri@chromium.org, Aug 2

Status: Fixed (was: Started)
►

Sign in to add a comment